git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH] Prettify log decorations even more
Date: Fri, 8 May 2009 03:45:07 -0400	[thread overview]
Message-ID: <20090508074507.GF12989@coredump.intra.peff.net> (raw)
In-Reply-To: <1241649948-11765-1-git-send-email-felipe.contreras@gmail.com>

On Thu, May 07, 2009 at 01:45:48AM +0300, Felipe Contreras wrote:

> -extern const char *prettify_ref(const struct ref *ref);
> +extern const char *prettify_refname(const char *refname);
> +#define prettify_ref(ref) prettify_refname((ref)->name)

I think it is an improvement for this function to take just the name,
but I don't see much point in keeping the crufty #define compatibility.
I would just fix up the few callers, as it really is just
s/ref/ref->name/.

-Peff

  reply	other threads:[~2009-05-08  7:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 22:45 [RFC/PATCH] Prettify log decorations even more Felipe Contreras
2009-05-08  7:45 ` Jeff King [this message]
2009-05-08  7:49   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090508074507.GF12989@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).