git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Ted Pavlic <ted@tedpavlic.com>, git@vger.kernel.org
Subject: Re: [PATCH] Speedup bash completion loading
Date: Fri, 9 Oct 2009 07:46:06 -0700	[thread overview]
Message-ID: <20091009144606.GT9261@spearce.org> (raw)
In-Reply-To: <20091009090958.GA4758@tugrik.mns.mnsspb.ru>

Kirill Smelkov <kirr@mns.spb.ru> wrote:
> On Thu, Oct 08, 2009 at 08:02:06AM -0700, Shawn O. Pearce wrote:
> > We probably should place a quick comment here to remind folks that
> > they need to build the script in order to test it properly.
> 
> I've added some sort of protection, so that git-completion.bash.in can't
> be sourced at all. Is it ok?

Yes, looks fine.

> Subject: [PATCH 2/2] bash: make git-completion.bash.generate bash agnostic

Squash this into the first patch and add the egrep change made by
Stephen Boyd "[PATCH 1/2] completion: fix completion of git <TAB><TAB>".
 
-- 
Shawn.

  reply	other threads:[~2009-10-09 14:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-05 10:03 [PATCH] Speedup bash completion loading Kirill Smelkov
2009-10-05 15:25 ` Shawn O. Pearce
2009-10-05 16:58   ` Kirill Smelkov
2009-10-05 19:18     ` Ted Pavlic
2009-10-08 13:27       ` Kirill Smelkov
2009-10-08 15:02         ` Shawn O. Pearce
2009-10-08 15:10           ` Kirill Smelkov
2009-10-09  9:09           ` Kirill Smelkov
2009-10-09 14:46             ` Shawn O. Pearce [this message]
2009-10-09 15:21               ` Kirill Smelkov
2009-10-09 15:39                 ` Shawn O. Pearce
2009-10-09 16:08                   ` Kirill Smelkov
2009-10-09 16:14                     ` Shawn O. Pearce
2009-10-10  0:57                       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091009144606.GT9261@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=kirr@mns.spb.ru \
    --cc=ted@tedpavlic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).