From: "SZEDER Gábor" <szeder@fzi.de>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] bash: support 'git notes' and its subcommands
Date: Thu, 28 Jan 2010 04:30:39 +0100 [thread overview]
Message-ID: <20100128033039.GB15202@neumann> (raw)
In-Reply-To: <201001280223.35625.johan@herland.net>
Hi Johan,
On Thu, Jan 28, 2010 at 02:23:35AM +0100, Johan Herland wrote:
> On Thursday 28 January 2010, SZEDER Gábor wrote:
> > ... and it will offer refs unless after -m or -F, because these two
> > options require a non-ref argument.
>
> Maybe-NAK.
>
> The patch is probably good in itself, and the intent is certainly good, but
> we're currently discussing deprecating the -m/-F options to "git notes edit"
> (see http://article.gmane.org/gmane.comp.version-control.git/138215), and if
> that's where we go, there's no point "encouraging" their use by adding bash-
> completions for them...
-m and -F are not encouraged, because they are not offered (short
options in general are never offered by the completion script).
However, their presence or absence is taken into account to offer
something sensible: refs after 'git notes edit <TAB>', files after
'git notes edit -F <TAB>'. Note, that I chose 'edit' here, because
currently it's the only subcommand taking '-F', but it will actually
work the same way with the upcoming 'add' and 'append' subcommands.
Best,
Gábor
[btw, Shawn, could you have a look at
http://article.gmane.org/gmane.comp.version-control.git/137754 ?]
next prev parent reply other threads:[~2010-01-28 3:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 1:05 [PATCH] bash: support 'git notes' and its subcommands SZEDER Gábor
2010-01-28 1:21 ` Shawn O. Pearce
2010-01-28 1:23 ` Johan Herland
2010-01-28 3:30 ` SZEDER Gábor [this message]
2010-01-28 10:02 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128033039.GB15202@neumann \
--to=szeder@fzi.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).