From: Jeff King <peff@peff.net>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix signal handler
Date: Sun, 14 Feb 2010 01:47:45 -0500 [thread overview]
Message-ID: <20100214064745.GC20630@coredump.intra.peff.net> (raw)
In-Reply-To: <4B76A985.9070809@web.de>
On Sat, Feb 13, 2010 at 02:30:45PM +0100, Markus Elfring wrote:
> > Why does this need to become extern?
>
> How do you think about to stress the detail that the function
> "log_show_early" is called by the function "limit_list" from an other
> translation unit.
Stress to whom? The keyword "extern" tells something to the linker, but
the linker doesn't care (and in fact making it extern introduces cruft
into the global namespace). If you want to tell the user, a comment
would be appropriate, but I don't think it is necessary. It is not hard
to see that the only use is assigning to an extern function pointer.
> > Overall, this change looks sane to me.
>
> How are the chances to get the update suggestion into the public Git
> repository?
You would have a better chance if you followed the directions in
SubmittingPatches, including sending it to the maintainer, including
your patch inline, and wrapping your commit message.
-Peff
next prev parent reply other threads:[~2010-02-14 6:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 16:14 Fix signal handler Markus Elfring
2010-02-02 20:58 ` Jeff King
2010-02-02 21:44 ` Markus Elfring
2010-02-02 22:32 ` Jeff King
2010-02-03 10:20 ` Markus Elfring
2010-02-03 10:29 ` Jeff King
2010-02-03 11:55 ` Markus Elfring
2010-02-03 13:12 ` Thomas Rast
2010-02-03 15:46 ` Markus Elfring
2010-02-03 15:52 ` Shawn O. Pearce
2010-02-03 15:53 ` Andreas Ericsson
2010-02-03 16:24 ` Markus Elfring
2010-02-04 7:23 ` Andreas Ericsson
2010-02-03 15:17 ` Jeff King
2010-02-03 16:04 ` Markus Elfring
2010-02-03 16:26 ` Bill Lear
2010-02-09 18:01 ` Markus Elfring
2010-02-09 23:49 ` Daniel Barkalow
2010-02-10 17:08 ` [PATCH] " Markus Elfring
2010-02-10 17:14 ` Shawn O. Pearce
2010-02-10 17:35 ` Jeff King
2010-02-10 17:33 ` Jeff King
2010-02-13 13:30 ` Markus Elfring
2010-02-14 6:47 ` Jeff King [this message]
2010-02-14 10:19 ` Junio C Hamano
2010-02-18 16:31 ` Markus Elfring
2010-02-18 20:06 ` Junio C Hamano
2010-02-19 11:05 ` Markus Elfring
2010-02-22 12:10 ` [PATCH] Fix a " Markus Elfring
2010-02-22 18:31 ` Junio C Hamano
2010-02-23 8:55 ` Markus Elfring
2010-02-23 9:10 ` Markus Elfring
2010-02-23 21:48 ` Junio C Hamano
2010-02-24 10:38 ` Markus Elfring
2010-02-24 10:51 ` Andreas Ericsson
2010-02-24 11:08 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214064745.GC20630@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Markus.Elfring@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).