git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Voigt <hvoigt@hvoigt.net>
To: Pat Thoyts <patthoyts@googlemail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org,
	msysGit Mailinglist <msysgit@googlegroups.com>
Subject: [PATCH v2] git-gui: fix usage of themed widgets variable
Date: Sat, 20 Feb 2010 19:57:57 +0100	[thread overview]
Message-ID: <20100220185757.GH15561@book.hvoigt.net> (raw)
In-Reply-To: <a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com>

There was one forgotten global so NS was not visible to the method
which resulted in an error.

The error was triggered by using git gui to clone a local repository.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
On Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:
> On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > There was one forgotten global so NS was not visible to the method
> > which resulted in an error.
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
[...]
> 
> The commit message should mention what triggered the error I think -
> but this patch is clearly correct.
> You can have a
> 
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> 
> if you like :)

Thanks, taken.

 git-gui/lib/status_bar.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
 }
 
 constructor two_line {path} {
+	global NS
 	set w $path
 	set w_l $w.l
 	set w_c $w.c
-- 
1.7.0.m5.rc2.13.g7abfa.dirty

      reply	other threads:[~2010-02-20 18:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-20 18:01 [PATCH] git-gui: fix usage of themed widgets variable Heiko Voigt
2010-02-20 18:47 ` Pat Thoyts
2010-02-20 18:57   ` Heiko Voigt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100220185757.GH15561@book.hvoigt.net \
    --to=hvoigt@hvoigt.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=msysgit@googlegroups.com \
    --cc=patthoyts@googlemail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).