From: Dmitry Potapov <dpotapov@gmail.com>
To: Jelmer Vernooij <jelmer@samba.org>
Cc: Jeff King <peff@peff.net>, Avery Pennarun <apenwarr@gmail.com>,
Ben Gamari <bgamari@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Storing (hidden) per-commit metadata
Date: Mon, 22 Feb 2010 17:20:13 +0300 [thread overview]
Message-ID: <20100222142013.GA7863@dpotapov.dyndns.org> (raw)
In-Reply-To: <1266846289.4575.69.camel@ganieda>
On Mon, Feb 22, 2010 at 02:44:49PM +0100, Jelmer Vernooij wrote:
> On Mon, 2010-02-22 at 16:08 +0300, Dmitry Potapov wrote:
> > I am not sure that the commit object is the right place to store that
> > metadata, but hidding this information is even more problematic. Let's
> > suppose that someone cherry-pick your Bazaar originated commit. Now when
> > you try to synchronize with Bazaar, your synchronizer will see that it
> > has some Bazaar revision ID and branch name, but, in fact, it is new
> > commit on a completely different branch...
> I don't see how the fact that the bzr-git/hg-git data is being hidden is
> the problem in the scenario you mention.
Because you can easily remove that information manually when you cherry-pick
some commit. It is more difficult to do when it is hidden.
> It'd be nice if this sort of information was discarded by "git rebase",
> but that's another good reason to treat it in a different way from the
> commit message instead.
Well, I do not see any other place in the commit object aside the commit
message where you can easily put information, and I do not think it is a
good idea for "git rebase" to edit the commit message automatically.
Maybe, you should look at git-notes. (I don't know enough about them to
tell whether they are suitable or not).
Dmitry
next prev parent reply other threads:[~2010-02-22 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 17:11 Storing (hidden) per-commit metadata Jelmer Vernooij
2010-02-20 17:41 ` Ben Gamari
2010-02-20 18:57 ` Avery Pennarun
2010-02-21 6:34 ` Jeff King
2010-02-21 8:49 ` Johannes Schindelin
2010-02-21 8:52 ` Jeff King
2010-02-21 12:17 ` Jelmer Vernooij
2010-02-22 5:17 ` Dmitry Potapov
2010-02-22 9:56 ` Jelmer Vernooij
2010-02-22 11:28 ` Dmitry Potapov
2010-02-22 11:59 ` Jelmer Vernooij
2010-02-22 13:08 ` Dmitry Potapov
2010-02-22 13:44 ` Jelmer Vernooij
2010-02-22 14:20 ` Dmitry Potapov [this message]
2010-02-22 19:13 ` Jelmer Vernooij
2010-02-22 14:57 ` Jelmer Vernooij
2010-02-22 5:11 ` Gabriel Filion
2010-02-22 9:49 ` Jelmer Vernooij
2010-02-22 22:13 ` "Alejandro R. Sedeño"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222142013.GA7863@dpotapov.dyndns.org \
--to=dpotapov@gmail.com \
--cc=apenwarr@gmail.com \
--cc=bgamari@gmail.com \
--cc=git@vger.kernel.org \
--cc=jelmer@samba.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).