From: Neil Horman <nhorman@tuxdriver.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Phil Hord <phil.hord@gmail.com>
Subject: Re: [PATCH 3/4] git-commit-am: Allow automatic rebasing to preserve empty commits
Date: Sat, 31 Mar 2012 09:03:08 -0400 [thread overview]
Message-ID: <20120331130308.GD2409@neilslaptop.think-freely.org> (raw)
In-Reply-To: <7v8vihlssj.fsf@alter.siamese.dyndns.org>
On Fri, Mar 30, 2012 at 01:47:56PM -0700, Junio C Hamano wrote:
> Neil Horman <nhorman@tuxdriver.com> writes:
>
> > Using the keep_empy environment variable, this change allows git-commit-am to
> > apply empty commits to the new branch we are rebasing to
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > CC: Jeff King <peff@peff.net>
> > CC: Phil Hord <phil.hord@gmail.com>
> > CC: Junio C Hamano <gitster@pobox.com>
> > ---
> > git-rebase--am.sh | 20 +++++++++++++++-----
> > 1 files changed, 15 insertions(+), 5 deletions(-)
> >
> > diff --git a/git-rebase--am.sh b/git-rebase--am.sh
> > index c815a24..c1d1b60 100644
> > --- a/git-rebase--am.sh
> > +++ b/git-rebase--am.sh
> > @@ -20,11 +20,21 @@ esac
> >
> > test -n "$rebase_root" && root_flag=--root
> >
> > -git format-patch -k --stdout --full-index --ignore-if-in-upstream \
> > - --src-prefix=a/ --dst-prefix=b/ \
> > - --no-renames $root_flag "$revisions" |
> > -git am $git_am_opt --rebasing --resolvemsg="$resolvemsg" &&
> > -move_to_original_branch
> > +if [ -n "$keep_empty" ]
> > +then
> > + # we have to do this the hard way. git format-patch completly squashes
> > + # empty commits and even if it didn't the format doesn't really lend
> > + # itself well to recording empty patches. fortunately, cherry-pick
> > + # makes this easy
> > + git cherry-pick --keep-empty "$revisions" && move_to_original_branch
>
> Does cherry-pick know the "--ignore-if-in-upstream" trick? Otherwise I
> suspect that this will introduce a severe regression to the command, as
> the commits that are already in the new base you are rebasing to will all
> be kept as empty commits, no?
>
Hmm, you may be correct. I'd not really thought of that. I can borrow the
format-patch code for that option and incorporate it into cherry-pick to fix
that up. Would that be sufficient?
Neil
next prev parent reply other threads:[~2012-03-31 13:03 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 19:48 [PATCH 0/4] Enhance git-rebases flexibiilty in handling empty commits Neil Horman
2012-03-30 19:48 ` [PATCH 1/4] git-cherry-pick: add keep-empty option Neil Horman
2012-03-30 20:34 ` Junio C Hamano
2012-03-30 21:15 ` Jeff King
2012-03-31 12:57 ` Neil Horman
2012-03-30 19:48 ` [PATCH 2/4] git-rebase: add keep_empty flag Neil Horman
2012-03-30 20:43 ` Junio C Hamano
2012-03-31 12:59 ` Neil Horman
2012-03-30 19:48 ` [PATCH 3/4] git-commit-am: Allow automatic rebasing to preserve empty commits Neil Horman
2012-03-30 20:46 ` Junio C Hamano
2012-03-31 13:01 ` Neil Horman
2012-03-30 20:47 ` Junio C Hamano
2012-03-31 13:03 ` Neil Horman [this message]
2012-03-30 19:48 ` [PATCH 4/4] git-commit-interactive: Allow " Neil Horman
2012-03-30 20:59 ` Junio C Hamano
2012-03-31 13:11 ` Neil Horman
2012-03-30 20:32 ` [PATCH 0/4] Enhance git-rebases flexibiilty in handling " Junio C Hamano
2012-04-05 19:39 ` [PATCH 0/5] Enhance git-rebases flexibiilty handling empty commits [v2] Neil Horman
2012-04-05 19:39 ` [PATCH 1/5] argv-array: Add argv_array_pop function [v2] Neil Horman
2012-04-05 20:12 ` Junio C Hamano
2012-04-05 23:24 ` Neil Horman
2012-04-06 0:12 ` Neil Horman
2012-04-06 0:19 ` Jeff King
2012-04-06 1:12 ` Neil Horman
2012-04-06 1:20 ` Junio C Hamano
2012-04-06 2:20 ` Jeff King
2012-04-06 4:19 ` Cc tags in the commit message (Re: [PATCH 1/5] argv-array: Add argv_array_pop function [v2]) Jonathan Nieder
2012-04-06 6:55 ` [PATCH 1/5] argv-array: Add argv_array_pop function [v2] Junio C Hamano
2012-04-06 7:33 ` Jeff King
2012-04-06 16:49 ` Junio C Hamano
2012-04-06 18:02 ` Neil Horman
2012-04-05 19:39 ` [PATCH 2/5] git-cherry-pick: add allow-empty option [v2] Neil Horman
2012-04-05 19:39 ` [PATCH 3/5] git-cherry-pick: Add ignore-if-made-empty " Neil Horman
2012-04-05 21:01 ` Junio C Hamano
2012-04-05 23:45 ` Neil Horman
2012-04-06 1:20 ` Junio C Hamano
2012-04-06 18:06 ` Neil Horman
2012-04-06 18:30 ` Johannes Sixt
2012-04-05 19:39 ` [PATCH 4/5] git-cherry-pick: Add test to validate new options [v2] Neil Horman
2012-04-05 19:39 ` [PATCH 5/5] git-rebase: add keep_empty flag [v2] Neil Horman
2012-04-10 15:47 ` [PATCH v3 0/4] Enhance git-rebases flexibiilty in handling empty commits Neil Horman
2012-04-10 15:47 ` [PATCH v3 1/4] git-cherry-pick: add allow-empty option Neil Horman
2012-04-10 16:45 ` Junio C Hamano
2012-04-10 18:13 ` Neil Horman
2012-04-10 19:32 ` Junio C Hamano
2012-04-10 20:00 ` Neil Horman
2012-04-10 20:32 ` Junio C Hamano
2012-04-10 20:39 ` Neil Horman
2012-04-10 21:09 ` Junio C Hamano
2012-04-11 0:44 ` Neil Horman
2012-04-11 16:52 ` Junio C Hamano
2012-04-11 18:29 ` Neil Horman
2012-04-11 18:50 ` Junio C Hamano
2012-04-11 18:56 ` Neil Horman
2012-04-10 15:47 ` [PATCH v3 2/4] git-cherry-pick: Add keep-redundant-commits option Neil Horman
2012-04-10 17:04 ` Junio C Hamano
2012-04-10 18:25 ` Neil Horman
2012-04-10 15:47 ` [PATCH v3 3/4] git-cherry-pick: Add test to validate new options Neil Horman
2012-04-10 15:47 ` [PATCH v3 4/4] git-rebase: add keep_empty flag Neil Horman
2012-04-13 18:45 ` [PATCH v5 0/4]Enhance git-rebases flexibiilty in handling empty commits Neil Horman
2012-04-13 18:45 ` [PATCH v5 1/4] git-cherry-pick: add allow-empty option Neil Horman
2012-04-13 18:45 ` [PATCH v5 2/4] git-cherry-pick: Add keep-redundant-commits option Neil Horman
2012-04-15 10:42 ` Clemens Buchacher
2012-04-16 15:38 ` Neil Horman
2012-04-16 22:10 ` Clemens Buchacher
2012-04-17 10:43 ` Neil Horman
2012-04-17 15:42 ` Junio C Hamano
2012-04-17 21:37 ` Clemens Buchacher
2012-04-18 10:41 ` Neil Horman
2012-04-13 18:45 ` [PATCH v5 3/4] git-cherry-pick: Add test to validate new options Neil Horman
2012-04-15 9:39 ` Clemens Buchacher
2012-04-16 11:04 ` Neil Horman
2012-04-16 16:14 ` Neil Horman
2012-04-16 16:35 ` Junio C Hamano
2012-04-16 16:50 ` Neil Horman
2012-04-16 21:42 ` Clemens Buchacher
2012-04-17 10:56 ` Neil Horman
2012-04-17 21:38 ` Clemens Buchacher
2012-04-18 10:48 ` Neil Horman
2012-04-18 18:34 ` Clemens Buchacher
2012-04-13 18:45 ` [PATCH v5 4/4] git-rebase: add keep_empty flag Neil Horman
2012-04-15 9:33 ` Clemens Buchacher
2012-04-16 16:46 ` Neil Horman
2012-04-17 18:20 ` [PATCH v6 0/4] Enhance git-rebases flexibiilty in handling empty commits Neil Horman
2012-04-17 18:20 ` [PATCH v6 1/4] git-cherry-pick: add allow-empty option Neil Horman
2012-04-17 18:20 ` [PATCH v6 2/4] git-cherry-pick: Add keep-redundant-commits option Neil Horman
2012-04-17 21:45 ` Clemens Buchacher
2012-04-18 10:49 ` Neil Horman
2012-04-17 18:20 ` [PATCH v6 3/4] git-cherry-pick: Add test to validate new options Neil Horman
2012-04-17 18:20 ` [PATCH v6 4/4] git-rebase: add keep_empty flag Neil Horman
2012-04-17 21:47 ` Clemens Buchacher
2012-04-18 10:50 ` Neil Horman
2012-04-18 22:58 ` Junio C Hamano
2012-04-19 13:08 ` Neil Horman
2012-04-19 17:53 ` Junio C Hamano
2012-04-18 19:17 ` [PATCH v7 0/4] Enhance git-rebases flexibiilty in handling empty commits Neil Horman
2012-04-18 19:17 ` [PATCH v7 1/4] git-cherry-pick: add allow-empty option Neil Horman
2012-04-18 19:17 ` [PATCH v7 2/4] git-cherry-pick: Add keep-redundant-commits option Neil Horman
2012-04-18 22:59 ` Junio C Hamano
2012-04-18 19:17 ` [PATCH v7 3/4] git-cherry-pick: Add test to validate new options Neil Horman
2012-04-18 19:18 ` [PATCH v7 4/4] git-rebase: add keep_empty flag Neil Horman
2012-04-19 10:02 ` Zbigniew Jędrzejewski-Szmek
2012-04-19 11:49 ` Thomas Rast
2012-04-19 12:19 ` Zbigniew Jędrzejewski-Szmek
2012-04-19 13:12 ` Neil Horman
2012-04-19 18:59 ` Junio C Hamano
2012-04-19 19:05 ` Junio C Hamano
2012-04-20 10:35 ` Neil Horman
2012-04-20 14:36 ` [PATCH v8 0/4] Enhance git-rebases flexibiilty in handling empty commits Neil Horman
2012-04-20 14:36 ` [PATCH v8 1/4] git-cherry-pick: add allow-empty option Neil Horman
2012-04-20 14:36 ` [PATCH v8 2/4] git-cherry-pick: Add keep-redundant-commits option Neil Horman
2012-04-20 19:21 ` Junio C Hamano
2012-04-20 19:56 ` Neil Horman
2012-04-20 14:36 ` [PATCH v8 3/4] git-cherry-pick: Add test to validate new options Neil Horman
2012-04-20 14:36 ` [PATCH v8 4/4] git-rebase: add keep_empty flag Neil Horman
2012-04-25 1:50 ` Junio C Hamano
2012-04-25 10:38 ` Neil Horman
2012-07-18 6:20 ` Martin von Zweigbergk
2012-07-18 7:10 ` Johannes Sixt
2012-07-18 7:16 ` Martin von Zweigbergk
2012-07-18 12:17 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331130308.GD2409@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).