From: Jeff King <peff@peff.net>
To: David Soria Parra <dsp@php.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] checkout: squelch "'mode' may be used uninitialized in this function" warning
Date: Tue, 8 May 2012 16:26:49 -0400 [thread overview]
Message-ID: <20120508202649.GA15502@sigill.intra.peff.net> (raw)
In-Reply-To: <slrnjq4p8c.i00.dsp@experimentalworks.net>
On Thu, May 03, 2012 at 10:59:24AM +0000, David Soria Parra wrote:
> Any update on this patch? Is it going to maint?
I doubt it:
> > diff --git a/builtin/checkout.c b/builtin/checkout.c
> > index 84d3eb3..6b8bf31 100644
> > --- a/builtin/checkout.c
> > +++ b/builtin/checkout.c
> > @@ -157,7 +157,7 @@ static int checkout_merged(int pos, struct checkout *state)
> > unsigned char sha1[20];
> > mmbuffer_t result_buf;
> > unsigned char threeway[3][20];
> > - unsigned mode;
> > + unsigned mode = mode;
What is this based on? This has been fixed since 335c6e4
(checkout_merged(): squelch false warning from some gcc, 2011-12-15),
which was in v1.7.8.2.
-Peff
prev parent reply other threads:[~2012-05-08 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 22:39 [PATCH] checkout: squelch "'mode' may be used uninitialized in this function" warning dsp
2012-05-03 10:59 ` David Soria Parra
2012-05-08 20:26 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508202649.GA15502@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dsp@php.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).