From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: git@vger.kernel.org Cc: kernel@pengutronix.de Subject: feature suggestion: optimize common parts for checkout --conflict=diff3 Date: Wed, 6 Mar 2013 16:05:48 +0100 [thread overview] Message-ID: <20130306150548.GC15375@pengutronix.de> (raw) Hello, Here comes another recipe for a different suggestion: git init echo 1 > file git add file git commit -m 'base' git branch branch seq 1 30 | grep -v 15 > file git commit -m 'add 2-30 without 15' file git checkout branch seq 1 30 | grep -v 16 > file git commit -m 'add 2-30 without 16' file git merge master git diff This yields: diff --cc file index a07e697,5080129..0000000 --- a/file +++ b/file @@@ -12,7 -12,7 +12,11 @@@ 12 13 14 ++<<<<<<< HEAD +15 ++======= + 16 ++>>>>>>> master 17 18 19 as expected; nice and sweet. After git checkout --conflict=diff3 file however the difference isn't that easy to spot any more. I expected diff --cc file index a07e697,5080129..0000000 --- a/file +++ b/file @@@ -12,7 -12,7 +12,12 @@@ 12 13 14 ++<<<<<<< ours +15 ++||||||| base ++======= + 16 ++>>>>>>> theirs 17 18 19 But instead I get diff --cc file index a07e697,5080129..0000000 --- a/file +++ b/file @@@ -1,29 -1,29 +1,61 @@@ 1 ++<<<<<<< ours +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +12 +13 +14 +15 +17 +18 +19 +20 +21 +22 +23 +24 +25 +26 +27 +28 +29 +30 ++||||||| base ++======= + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 + 10 + 11 + 12 + 13 + 14 + 16 + 17 + 18 + 19 + 20 + 21 + 22 + 23 + 24 + 25 + 26 + 27 + 28 + 29 + 30 ++>>>>>>> theirs Of course this is technically correct, just not maximally helpful. Is this a missing optimisation for the diff3 case or did I miss a detail that makes my expectation wrong? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
next reply other threads:[~2013-03-06 15:06 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-06 15:05 Uwe Kleine-König [this message] 2013-03-06 18:27 ` Antoine Pelisse 2013-03-06 19:26 ` Antoine Pelisse 2013-03-06 20:03 ` Jeff King 2013-03-06 20:36 ` [PATCH] xdiff: implement a zealous diff3 Uwe Kleine-König 2013-03-06 20:46 ` Jeff King 2013-03-06 20:40 ` feature suggestion: optimize common parts for checkout --conflict=diff3 Junio C Hamano 2013-03-06 20:54 ` Jeff King 2013-03-06 21:09 ` Junio C Hamano 2013-03-06 21:21 ` Jeff King 2013-03-06 21:50 ` Junio C Hamano 2013-03-07 1:02 ` Jeff King 2013-03-06 21:31 ` Uwe Kleine-König 2013-03-06 21:32 ` Junio C Hamano 2013-03-07 8:04 ` Jeff King 2013-03-07 17:26 ` Junio C Hamano 2013-03-07 18:01 ` Jeff King 2013-03-07 18:40 ` Junio C Hamano 2013-03-07 18:50 ` Jeff King 2013-04-04 20:33 ` Jeff King 2013-04-04 20:49 ` Uwe Kleine-König 2013-04-04 20:54 ` Jeff King 2013-04-04 21:19 ` Junio C Hamano 2013-03-07 18:21 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130306150548.GC15375@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=git@vger.kernel.org \ --cc=kernel@pengutronix.de \ --subject='Re: feature suggestion: optimize common parts for checkout --conflict=diff3' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).