From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Date: Wed, 20 Mar 2013 13:26:40 -0400 Message-ID: <20130320172640.GC10752@sigill.intra.peff.net> References: <5149724C.3060105@viscovery.net> <20130320093313.GA9482@sigill.intra.peff.net> <51499DE7.2030404@viscovery.net> <20130320170607.GB10752@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Git Mailing List To: Johannes Sixt X-From: git-owner@vger.kernel.org Wed Mar 20 18:27:19 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UIMnD-0002V5-Q7 for gcvg-git-2@plane.gmane.org; Wed, 20 Mar 2013 18:27:16 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844Ab3CTR0r (ORCPT ); Wed, 20 Mar 2013 13:26:47 -0400 Received: from 75-15-5-89.uvs.iplsin.sbcglobal.net ([75.15.5.89]:60266 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab3CTR0r (ORCPT ); Wed, 20 Mar 2013 13:26:47 -0400 Received: (qmail 9777 invoked by uid 107); 20 Mar 2013 17:28:30 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Wed, 20 Mar 2013 13:28:30 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 20 Mar 2013 13:26:40 -0400 Content-Disposition: inline In-Reply-To: <20130320170607.GB10752@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Mar 20, 2013 at 01:06:07PM -0400, Jeff King wrote: > On Wed, Mar 20, 2013 at 12:30:47PM +0100, Johannes Sixt wrote: > > > > I think that is OK, but I'm curious why this is a problem _now_, and not > > > with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also > > > just calling write() to descriptor 3. > > > > Before this change, both affected commands completed and the trace file > > was empty. Notice that in both test cases we only check for the absence of > > certain lines, which is naturally true for an empty file, so that the > > tests pass. > > Hmm. The code in t5503 is similar, but before my patch used to actually > use "test -s" to make sure that some trace output was written. Did it > fail before 97a83fa8 (and does it pass now)? Ah, I see. It did fail, and it was marked with NOT_MINGW. I think we can fix that now. Patch coming in a moment. -Peff