From: Jonathan Nieder <jrnieder@gmail.com>
To: David Kastrup <dak@gnu.org>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
d9ba@mailtor.net, git@vger.kernel.org
Subject: Re: Harmful LESS flags
Date: Thu, 24 Apr 2014 16:08:12 -0700 [thread overview]
Message-ID: <20140424230812.GM15516@google.com> (raw)
In-Reply-To: <87ha5i9wkp.fsf@fencepost.gnu.org>
Hi,
David Kastrup wrote:
> Jeff King <peff@peff.net> writes:
>> There are two questions here:
>>
>> 1. Can less do a better job of indicating what's in the input when -S
>> is in effect?
>>
>> 2. What should get put into $LESS by default?
>>
>> I was specifically addressing (1). Your comment does not help at all
>> there.
>>
>> It could have an impact on (2), but you didn't say anything besides "I
>> don't like it". That doesn't add anything to the conversation.
>
> No, I said it is useless, which is different from "I don't like it".
> The information is not copy&pastable from a terminal window since it is
> cut off. It is also useless for review since one does not actually know
> what's in there. The only thing it has going for it is that it's
> prettier than the actually usable information.
I disagree with your characterization of what's useful here, but it
really doesn't matter. Why are you still arguing?
I think it would be fine to change git's default for LESS to FRX and
document that change wherever the documentation currently mentions
FRSX, if someone wants to write a patch for it. (Such a change would
sit in "pu" or "next" until after 2.0.0 is released, of course.)
In the meantime, when you're on machines using the current default,
you have two choices:
a) set the LESS envvar in your .profile explicitly
b) hit the two keys '-', shift+S when git opens a pager
The argument about safety is a red herring here, since it's always
possible that a patch will wrap to make new lines with '+' or '-' or
'@@' at the beginning that are equally confusing.
Hoping that clarifies,
Jonathan
next prev parent reply other threads:[~2014-04-24 23:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 23:46 Harmful LESS flags d9ba
2014-04-24 0:11 ` Jonathan Nieder
2014-04-28 21:38 ` Mark Nudelman
2014-04-24 5:06 ` David Kastrup
2014-04-24 19:02 ` Junio C Hamano
2014-04-24 19:21 ` David Kastrup
2014-04-24 19:29 ` Junio C Hamano
2014-04-24 19:50 ` David Kastrup
2014-04-24 21:35 ` Jeff King
2014-04-24 21:47 ` Junio C Hamano
2014-04-24 22:02 ` Jeff King
2014-04-24 21:48 ` David Kastrup
2014-04-24 22:13 ` Jeff King
2014-04-24 22:44 ` David Kastrup
2014-04-24 23:08 ` Jonathan Nieder [this message]
2014-04-25 6:56 ` Matthieu Moy
2014-04-25 15:11 ` Jonathan Nieder
2014-04-25 15:32 ` David Kastrup
2014-04-25 15:47 ` Jonathan Nieder
2014-04-28 8:34 ` [PATCH] PAGER_ENV: remove 'S' from $LESS by default Matthieu Moy
2014-04-28 8:43 ` David Kastrup
2014-04-28 8:59 ` Matthieu Moy
2014-04-28 9:14 ` David Kastrup
2014-04-28 12:22 ` Matthieu Moy
2014-04-28 16:24 ` Jeff King
2014-04-28 18:48 ` Junio C Hamano
2014-04-29 12:29 ` Matthieu Moy
2014-04-29 17:01 ` Junio C Hamano
2014-04-30 7:35 ` [PATCH v2] pager: " Matthieu Moy
2014-04-30 15:38 ` Junio C Hamano
2014-04-30 15:49 ` Matthieu Moy
2014-04-30 17:34 ` Junio C Hamano
2014-05-05 18:44 ` Jonathan Nieder
2014-05-05 20:10 ` Matthieu Moy
2014-05-06 17:34 ` Junio C Hamano
2014-05-06 18:00 ` David Kastrup
2014-05-06 18:49 ` Matthieu Moy
2014-05-06 21:55 ` Jeff King
2014-05-07 17:07 ` Junio C Hamano
2014-05-07 17:54 ` Matthieu Moy
2014-05-07 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424230812.GM15516@google.com \
--to=jrnieder@gmail.com \
--cc=d9ba@mailtor.net \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).