From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH] prefix_path(): Unconditionally free result of prefix_path
Date: Tue, 5 May 2015 13:56:12 -0400 [thread overview]
Message-ID: <20150505175612.GA9709@peff.net> (raw)
In-Reply-To: <xmqqr3qvdizd.fsf@gitster.dls.corp.google.com>
On Tue, May 05, 2015 at 10:36:38AM -0700, Junio C Hamano wrote:
> Stefan Beller <sbeller@google.com> writes:
>
> >> Should we also squash in these sites? I think they are adequately
> >> covered under the proposed log message.
> >
> > That sounds good to me.
> >>
> >> Found by grepping for prefix_path calls. The only remainders are:
> >>
> >> 1. in blame, we assign the result to a const char that may also point
> >> straight into to argv, but we never actually free either way
>
> The return value from add_prefix() that is what prefix_path()
> returned eventually becomes scoreboard.path that needs to be kept
> during the lifetime of the process, and I think there isn't much
> point doing the "free() immediately before exiting".
Yeah, sorry, I meant to say that more explicitly, but clearly didn't. I
think it is fine as-is.
> Anyway, here is what I'd queue for now.
Looks good, thanks.
-Peff
next prev parent reply other threads:[~2015-05-05 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 19:11 [PATCH] prefix_path(): Unconditionally free result of prefix_path Stefan Beller
2015-05-04 20:19 ` Eric Sunshine
2015-05-04 22:29 ` Junio C Hamano
2015-05-05 3:21 ` Jeff King
2015-05-05 16:28 ` Stefan Beller
2015-05-05 17:36 ` Junio C Hamano
2015-05-05 17:56 ` Jeff King [this message]
2015-05-05 18:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505175612.GA9709@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).