From: Adam Dinwoodie <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: Johannes Schindelin <firstname.lastname@example.org>, "brian m. carlson" <email@example.com>, Mark Levedahl <firstname.lastname@example.org>, email@example.com, Eric Blake <firstname.lastname@example.org>, "Shawn O . Pearce" <email@example.com>, Ramsay Jones <firstname.lastname@example.org> Subject: Re: [PATCH] config.mak.uname: Cygwin: Use renames for creation Date: Tue, 11 Aug 2015 11:05:27 +0100 Message-ID: <20150811100527.GW14466@dinwoodie.org> (raw) In-Reply-To: <email@example.com> On Mon, Aug 10, 2015 at 12:08:29PM -0700, Junio C Hamano wrote: > But in the end, I'd prefer the choice of the compiled-in default up > to the port maintainers. You earlier said: > > This problem was reported on the Cygwin mailing list at > https://cygwin.com/ml/cygwin/2015-08/msg00102.html (amongst others) and > is being applied as a manual patch to the Cygwin builds until the patch > is taken here. > > so my preference is to see Cygwin continue to do so for a couple > release cycles of ours to make sure all Cygwin end-users are happy > and consider the flip of the default a good change for them, and > then the official Cygwin packager of Git sends a patch our way. Wait a few releases then resubmit assuming we've not had complaints from Cygwin user. Okay! > https://cygwin.com/ml/cygwin/2015-08/msg00102.html seems to indicate > that somebody called Adam Dinwoodie is wearing Git maintainer hat, > so perhaps you may be that "official Cygwin packager of Git" ;-) That would indeed be yours truly :) > I agree with everything you said in that message to Peter---the > patch should be included when you hear reports of `git config > core.createObject rename` helping more people. After versions of > Cygwin Git package with such a change proves good, let's reduce the > workload of Cygwin Git maintainer by upstreaming that change to my > tree. But not before. Cool. FWIW, the reason we've started applying this patch to the downstream Cygwin builds is that I've now seen a number of reports (primarily on Stack Overflow) of this problem where that config change has fixed things. I'd been holding off until I had those extra reports, but now I have them I made the patch and figured I'd submit it upstream at the same time. As above, I'll wait a while until we're happy it's stable, and resubmit at that point. (On which note, I should probably submit the patch to the git-gui Makefile we've had in our builds since back in v1.7.9, before I took over the maintainership, since that one clearly is pretty stable...) Thanks!
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-07 20:30 Adam Dinwoodie 2015-08-08 20:47 ` Mark Levedahl 2015-08-08 21:06 ` brian m. carlson 2015-08-09 2:01 ` Adam Dinwoodie 2015-08-09 9:01 ` Johannes Schindelin 2015-08-09 17:05 ` Adam Dinwoodie 2015-08-10 19:08 ` Junio C Hamano 2015-08-11 10:05 ` Adam Dinwoodie [this message] 2015-08-18 15:44 ` Johannes Schindelin
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150811100527.GW14466@dinwoodie.org \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Mailing List Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/git/0 git/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 git git/ https://lore.kernel.org/git \ email@example.com public-inbox-index git Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git