From: Adam Dinwoodie <adam@dinwoodie.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Mark Levedahl <mlevedahl@gmail.com>,
Eric Blake <eblake@redhat.com>,
"Shawn O . Pearce" <spearce@spearce.org>
Subject: [PATCH resubmission] config.mak.uname: Cygwin: Use renames for creation
Date: Tue, 19 Apr 2016 10:10:55 +0100 [thread overview]
Message-ID: <20160419091055.GF2345@dinwoodie.org> (raw)
When generating build options for Cygwin, enable
OBJECT_CREATION_USES_RENAMES. This is necessary to use Git on Windows
shared directories, and is already enabled for the MinGW and plain
Windows builds.
Reported-by: Peter Rosin <peda@lysator.liu.se>
Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>
---
This patch has previously been discussed on the mailing list (see
http://thread.gmane.org/gmane.comp.version-control.git/275485), back in
August 2015. The conclusion then was that the downstream Cygwin builds
should take this patch for a few Git releases, and then resubmit the
patch to be taken upstream if it was causing no problems.
As the Cygwin Git maintainer, I've been applying this patch downstream
since v2.4.5-3 (where the "-3" is the Cygwin build/patch number), and
I've seen no reports of problems caused by this patch, and the reports
of Git on Cygwin being unable to work with Windows shared directories
have stopped. As such, I'm resubmitting.
config.mak.uname | 1 +
1 file changed, 1 insertion(+)
diff --git a/config.mak.uname b/config.mak.uname
index 943c439..be5cbec 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -187,6 +187,7 @@ ifeq ($(uname_O),Cygwin)
X = .exe
UNRELIABLE_FSTAT = UnfortunatelyYes
SPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield
+ OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
endif
ifeq ($(uname_S),FreeBSD)
NEEDS_LIBICONV = YesPlease
--
2.4.5
reply other threads:[~2016-04-19 9:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419091055.GF2345@dinwoodie.org \
--to=adam@dinwoodie.org \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=mlevedahl@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).