From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com, dwwang@google.com,
e@80x24.org, dennis@kaarsemaker.net, jrnieder@gmail.com
Subject: Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options
Date: Thu, 14 Jul 2016 18:46:17 -0400 [thread overview]
Message-ID: <20160714224617.GA22386@sigill.intra.peff.net> (raw)
In-Reply-To: <20160714214948.27432-2-sbeller@google.com>
On Thu, Jul 14, 2016 at 02:49:45PM -0700, Stefan Beller wrote:
> We limit the push options for now
> * to not exceed an arbitrary count, and
> * to not exceed an arbitrary size.
>
> This serves two purposes:
> * DoS protection (i.e. one connection can add no more than 32kB
> now)
> * We need to figure out how to handle large (>64kB). Jeff wrote:
> > Yes, but people are also happy when they can use a flexible and
> > standardized tool to do a thing. I'd be more frustrated when I found out
> > that Git's data-pushing protocol has arbitrary limitations (like, say, I
> > can't push a data item larger than a single 64K pkt-line), which would
> > easily just work with something like HTTP POSTs.
> So to keep a way open in the future to deal with large pay loads,
> the size is restricted for now.
Should this bit get dropped from the commit message?
-Peff
next prev parent reply other threads:[~2016-07-14 22:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 21:49 [PATCHv7 0/4] Push options Stefan Beller
2016-07-14 21:49 ` [PATCH 1/4] push options: {pre,post}-receive hook learns about push options Stefan Beller
2016-07-14 22:46 ` Jeff King [this message]
2016-07-14 22:51 ` Stefan Beller
2016-07-14 21:49 ` [PATCH 2/4] receive-pack: implement advertising and receiving " Stefan Beller
2016-07-14 21:49 ` [PATCH 3/4] push: accept " Stefan Beller
2016-07-14 21:49 ` [PATCH 4/4] add a test for " Stefan Beller
2016-07-14 22:38 ` [PATCHv7 0/4] Push options Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-07-14 17:39 [PATCHv5 " Stefan Beller
2016-07-14 17:39 ` [PATCH 1/4] push options: {pre,post}-receive hook learns about push options Stefan Beller
2016-07-09 0:31 [PATCHv4 0/4] Push options Stefan Beller
2016-07-09 0:31 ` [PATCH 1/4] push options: {pre,post}-receive hook learns about push options Stefan Beller
2016-07-07 1:12 [PATCHv3 0/4] Push options in C Git Stefan Beller
2016-07-07 1:12 ` [PATCH 1/4] push options: {pre,post}-receive hook learns about push options Stefan Beller
2016-07-07 20:20 ` Junio C Hamano
2016-07-07 21:50 ` Stefan Beller
2016-07-07 21:53 ` Junio C Hamano
2016-06-30 0:59 [RFC PATCHv1 0/4] Push options in C Git Stefan Beller
2016-06-30 0:59 ` [PATCH 1/4] push options: {pre,post}-receive hook learns about push options Stefan Beller
2016-07-01 7:14 ` Jeff King
2016-07-01 17:20 ` Stefan Beller
2016-07-01 17:59 ` Jeff King
2016-07-01 18:03 ` Junio C Hamano
2016-07-01 18:11 ` Jeff King
2016-07-01 19:25 ` Junio C Hamano
2016-07-01 19:31 ` Stefan Beller
2016-07-01 19:39 ` Jeff King
2016-07-01 19:50 ` Stefan Beller
2016-07-01 18:40 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714224617.GA22386@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dennis@kaarsemaker.net \
--cc=dwwang@google.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).