From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
git@vger.kernel.org, Thomas Gummerer <t.gummerer@gmail.com>,
Andrew Arnott <Andrew.Arnott@microsoft.com>
Subject: Re: [PATCH v2 2/2] Be more careful when determining whether a remote was configured
Date: Thu, 19 Jan 2017 16:50:17 -0500 [thread overview]
Message-ID: <20170119215016.j675tzhmhcku2y43@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqy3y6yb9i.fsf@gitster.mtv.corp.google.com>
On Thu, Jan 19, 2017 at 01:45:29PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I'm trying to figure out why "fetch --multiple" wouldn't just take a url
> > in the first place. I guess it is because multiple fetch is useless
> > without refspecs (since otherwise you're just writing to FETCH_HEAD,
> > which gets immediately overwritten).
>
> This is probably a tangent, if FETCH_HEAD is overwritten, wouldn't
> that be a bug in the implementation of --multiple? I somehow
> thought we had an option to tell second and subsequent "fetch" to
> append to FETCH_HEAD instead of overwriting it.
Maybe. I was just speculating on the reason.
I just disabled that check and tried it with two local repos:
git init
git fetch --multiple /path/to/one /path/to/two
cat .git/FETCH_HEAD
and indeed it does seem to append.
The logic comes from 9c4a036b3 (Teach the --all option to 'git fetch',
2009-11-09), but it does not seem to give any reasoning. Nor could I
find anything on the mailing list. <shrug>
-Peff
prev parent reply other threads:[~2017-01-19 21:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 21:18 [PATCH 0/2] Fix remote_is_configured() Johannes Schindelin
2017-01-17 21:19 ` [PATCH 1/2] remote rename: demonstrate a bogus "remote exists" bug Johannes Schindelin
2017-01-17 21:19 ` [PATCH 2/2] Be more careful when determining whether a remote was configured Johannes Schindelin
2017-01-17 21:47 ` Jeff King
2017-01-17 22:19 ` Junio C Hamano
2017-01-18 12:38 ` Johannes Schindelin
2017-01-18 12:34 ` Johannes Schindelin
2017-01-18 12:54 ` Jeff King
2017-01-18 16:22 ` Johannes Schindelin
2017-01-19 18:27 ` Jeff King
2017-01-19 20:12 ` Junio C Hamano
2017-01-19 20:22 ` Jeff King
2017-01-19 21:19 ` Johannes Schindelin
2017-01-17 21:45 ` [PATCH 0/2] Fix remote_is_configured() Jeff King
2017-01-19 21:19 ` [PATCH v2 " Johannes Schindelin
2017-01-19 21:19 ` [PATCH v2 1/2] remote rename: demonstrate a bogus "remote exists" bug Johannes Schindelin
2017-01-19 21:20 ` [PATCH v2 2/2] Be more careful when determining whether a remote was configured Johannes Schindelin
2017-01-19 21:31 ` Jeff King
2017-01-19 21:44 ` Johannes Schindelin
2017-01-19 21:45 ` Junio C Hamano
2017-01-19 21:50 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119215016.j675tzhmhcku2y43@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Andrew.Arnott@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).