git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Øyvind A. Holm" <sunny@sunbase.org>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH 6/7] Documentation: move dblatex arguments into variable
Date: Sun, 22 Jan 2017 02:03:47 +0100	[thread overview]
Message-ID: <20170122010346.iywz4rqqzewfmhkn@sunbase.org> (raw)
In-Reply-To: <20170121215912.246691-7-sandals@crustytoothpaste.net>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On 2017-01-21 21:59:11, brian m. carlson wrote:
> Our dblatex invocation uses several style components from the AsciiDoc
> distribution, but those components are not available when building with
> Asciidoctor.  Move the command line arguments into a variable so it can
> be overridden by the user or makefile configuration options.
> [...]
> -	$(DBLATEX) -o $@+ -p $(ASCIIDOC_DBLATEX_DIR)/asciidoc-dblatex.xsl -s $(ASCIIDOC_DBLATEX_DIR)/asciidoc-dblatex.sty $< && \
> +	$(DBLATEX) $-o $@+ (DBLATEX_COMMON) $< && \

It looks as the dollar sign is in the wrong place, should be in front of 
(DBLATEX_COMMON).

Regards,
Øyvind

+-| Øyvind A. Holm <sunny@sunbase.org> - N 60.37604° E 5.33339° |-+
| OpenPGP: 0xFB0CBEE894A506E5 - http://www.sunbase.org/pubkey.asc |
| Fingerprint: A006 05D6 E676 B319 55E2  E77E FB0C BEE8 94A5 06E5 |
+------------| 61815930-e03e-11e6-b4f4-db5caa6d21d3 |-------------+

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-01-22  1:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 21:59 [PATCH 0/7] Macro for Asciidoctor support brian m. carlson
2017-01-21 21:59 ` [PATCH 1/7] Documentation: fix warning in cat-texi.perl brian m. carlson
2017-01-21 21:59 ` [PATCH 2/7] Documentation: modernize cat-texi.perl brian m. carlson
2017-01-21 21:59 ` [PATCH 3/7] Documentation: remove unneeded argument in cat-texi.perl brian m. carlson
2017-01-21 21:59 ` [PATCH 4/7] Documentation: sort sources for gitman.texi brian m. carlson
2017-01-21 21:59 ` [PATCH 5/7] Documentation: add XSLT to fix DocBook for Texinfo brian m. carlson
2017-01-21 21:59 ` [PATCH 6/7] Documentation: move dblatex arguments into variable brian m. carlson
2017-01-22  1:03   ` Øyvind A. Holm [this message]
2017-01-21 21:59 ` [PATCH 7/7] Makefile: add a knob to enable the use of Asciidoctor brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170122010346.iywz4rqqzewfmhkn@sunbase.org \
    --to=sunny@sunbase.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).