Re: [PATCH 2/7] completion: add subcommand completion for rerere

From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Cornelius Weig <cornelius.weig@tngtech.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	bitte.keine.werbung.einwerfen@googlemail.com,
	thomas.braun@virtuell-zuhause.de, john@keeping.me.uk,
	git@vger.kernel.org
Subject: Re: [PATCH 2/7] completion: add subcommand completion for rerere
Date: Thu,  2 Feb 2017 01:57:24 +0100	[thread overview]
Message-ID: <20170202005724.24754-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20170122225724.19360-3-cornelius.weig@tngtech.com>

> Managing recorded resolutions requires command-line usage of git-rerere.
> Added subcommand completion for rerere and path completion for its
> subcommand forget.
> ---
>  contrib/completion/git-completion.bash | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index c54a557..8329f09 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2401,6 +2401,17 @@ _git_replace ()
>  	__gitcomp_nl "$(__git_refs)"
>  }
>  
> +_git_rerere ()
> +{
> +	local subcommands="clear forget diff remaining status gc"
> +	local subcommand="$(__git_find_on_cmdline "$subcommands")"
> +	if test -z "$subcommand"
> +	then
> +		__gitcomp "$subcommands"
> +		return
> +	fi
> +}
> +
>  _git_reset ()
>  {
>  	__git_has_doubledash && return
> -- 
> 2.10.2

You didn't add 'rerere' to the list of porcelain commands, i.e. it
won't be listed after 'git <TAB><TAB>'.  I'm not saying it should be
listed there, because I can't decide whether 'rerere' is considered
porcelain or plumbing...  Just wanted to make sure that this omission
was intentional.