From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ben Peart <peartben@gmail.com>,
git@vger.kernel.org, benpeart@microsoft.com,
christian.couder@gmail.com, larsxschneider@gmail.com
Subject: Re: [PATCH v7 00/10] refactor the filter process code into a reusable module
Date: Sat, 13 May 2017 05:16:37 -0400 [thread overview]
Message-ID: <20170513091637.zebzyi7ggidybzak@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqfuggaz3d.fsf@gitster.mtv.corp.google.com>
On Mon, May 08, 2017 at 10:58:46AM +0900, Junio C Hamano wrote:
> Will queue; during the pre-release freeze, new things would move
> slowly, but let's see if we have more comments from others and then
> merge it to 'next' soon after the 2.13 final.
I gave it a fresh read-through. I had a few comments, but nothing that I
think should hold up moving these patches to 'next'.
I do find the convert/sub-process split a little funny. Most of the
protocol bits from convert didn't get moved over, and you could use a
sub-process that spoke any arbitrary protocol. The odd man out is
subprocess_read_status(), which assumes not only pktlines, but also
a "status=foo" key/value pair inside them.
I have a feeling that funny split is because this is a preliminary
refactoring step that will have more features built on it, and the end
result may be more consistent. We _could_ hold these back and pass
judgement once we see more. But they're a reasonable-sized chunk that's
already been through 7 rounds of review. It makes sense to me to
graduate them at least to 'next' and let the next steps use them as a
stable base.
-Peff
prev parent reply other threads:[~2017-05-13 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 15:27 [PATCH v7 00/10] refactor the filter process code into a reusable module Ben Peart
2017-05-05 15:27 ` [PATCH v7 01/10] convert: remove erroneous tests for errno == EPIPE Ben Peart
2017-05-05 15:27 ` [PATCH v7 02/10] pkt-line: fix packet_read_line() to handle len < 0 errors Ben Peart
2017-05-05 15:27 ` [PATCH v7 03/10] pkt-line: add packet_read_line_gently() Ben Peart
2017-05-05 15:27 ` [PATCH v7 04/10] convert: move packet_write_line() into pkt-line as packet_writel() Ben Peart
2017-05-13 9:04 ` Jeff King
2017-05-15 4:02 ` Junio C Hamano
2017-05-05 15:27 ` [PATCH v7 05/10] convert: split start_multi_file_filter() into two separate functions Ben Peart
2017-05-05 15:27 ` [PATCH v7 06/10] convert: Separate generic structures and variables from the filter specific ones Ben Peart
2017-05-05 15:27 ` [PATCH v7 07/10] convert: Update generic functions to only use generic data structures Ben Peart
2017-05-05 15:28 ` [PATCH v7 08/10] convert: rename reusable sub-process functions Ben Peart
2017-05-05 15:28 ` [PATCH v7 09/10] sub-process: move sub-process functions into separate files Ben Peart
2017-05-13 9:07 ` Jeff King
2017-05-05 15:28 ` [PATCH v7 10/10] convert: Update subprocess_read_status to not die on EOF Ben Peart
2017-05-08 1:58 ` [PATCH v7 00/10] refactor the filter process code into a reusable module Junio C Hamano
2017-05-13 9:16 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170513091637.zebzyi7ggidybzak@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=benpeart@microsoft.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).