Re: [PATCH v2 00/13] object_id part 9

From: Brandon Williams <bmwill@google.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Stefan Beller <stefanbeller@gmail.com>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 00/13] object_id part 9
Date: Fri, 14 Jul 2017 12:35:35 -0700	[thread overview]
Message-ID: <20170714193535.GA50015@google.com> (raw)
In-Reply-To: <20170713234930.949612-1-sandals@crustytoothpaste.net>

On 07/13, brian m. carlson wrote:
> This is the ninth in a series of series to convert Git to use struct
> object_id.  This series converts the remaining callers of get_sha1 and
> friends to take and use struct object_id, and in doing so, renames them
> to get_oid and friends.
> 
> This patch should probably be based Stefan Beller's series, in which case
> patch 9 can be dropped.
> 
> Changes from v1:
> * Restore the check for length in get_sha1_basic.
> * Add a patch converting some uses of 40 to GIT_SHA1_HEXSZ as suggested.  This
>   is a separate patch because I wanted to minimize the non-automated portions of
>   the patch in question.
> 

I've looked through v2 and it looks good to me as nothing crazy stood
out to me.

Thanks!

> brian m. carlson (13):
>   builtin/fsck: convert remaining caller of get_sha1 to object_id
>   builtin/merge-tree: convert remaining caller of get_sha1 to object_id
>   submodule: convert submodule config lookup to use object_id
>   remote: convert struct push_cas to struct object_id
>   sequencer: convert to struct object_id
>   builtin/update_ref: convert to struct object_id
>   bisect: convert bisect_checkout to struct object_id
>   builtin/unpack-file: convert to struct object_id
>   builtin/verify-tag: convert to struct object_id
>   Convert remaining callers of get_sha1 to get_oid.
>   sha1_name: convert get_sha1* to get_oid*
>   sha1_name: convert GET_SHA1* flags to GET_OID*
>   sha1_name: convert uses of 40 to GIT_SHA1_HEXSZ
> 
>  apply.c                          |   4 +-
>  archive.c                        |   2 +-
>  bisect.c                         |  18 +--
>  builtin/am.c                     |   6 +-
>  builtin/cat-file.c               |   8 +-
>  builtin/commit-tree.c            |   4 +-
>  builtin/commit.c                 |   8 +-
>  builtin/fsck.c                   |   8 +-
>  builtin/grep.c                   |   8 +-
>  builtin/log.c                    |   4 +-
>  builtin/merge-tree.c             |   6 +-
>  builtin/receive-pack.c           |   4 +-
>  builtin/replace.c                |   4 +-
>  builtin/reset.c                  |  10 +-
>  builtin/rev-parse.c              |   8 +-
>  builtin/show-branch.c            |   8 +-
>  builtin/submodule--helper.c      |   8 +-
>  builtin/unpack-file.c            |  12 +-
>  builtin/update-ref.c             |  69 ++++++-----
>  builtin/verify-tag.c             |   8 +-
>  cache.h                          |  45 ++++----
>  commit.c                         |   4 +-
>  config.c                         |  12 +-
>  config.h                         |   4 +-
>  mailmap.c                        |   6 +-
>  notes.c                          |   2 +-
>  refs.c                           |   2 +-
>  remote.c                         |   8 +-
>  remote.h                         |   2 +-
>  repository.c                     |   2 +-
>  revision.c                       |  16 +--
>  sequencer.c                      |  65 +++++------
>  sha1_name.c                      | 240 +++++++++++++++++++--------------------
>  submodule-config.c               |  38 +++----
>  submodule-config.h               |  12 +-
>  submodule.c                      |  32 +++---
>  submodule.h                      |   2 +-
>  t/helper/test-submodule-config.c |  10 +-
>  transport-helper.c               |   2 +-
>  39 files changed, 351 insertions(+), 360 deletions(-)
> 

-- 
Brandon Williams