From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0120F1F991 for ; Thu, 3 Aug 2017 19:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbdHCT3z (ORCPT ); Thu, 3 Aug 2017 15:29:55 -0400 Received: from cloud.peff.net ([104.130.231.41]:57320 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751251AbdHCT3z (ORCPT ); Thu, 3 Aug 2017 15:29:55 -0400 Received: (qmail 8827 invoked by uid 109); 3 Aug 2017 19:29:51 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 03 Aug 2017 19:29:51 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 22084 invoked by uid 111); 3 Aug 2017 19:30:10 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with SMTP; Thu, 03 Aug 2017 15:30:10 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 03 Aug 2017 15:29:47 -0400 Date: Thu, 3 Aug 2017 15:29:47 -0400 From: Jeff King To: Martin =?utf-8?B?w4VncmVu?= Cc: git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH v3 0/7] tag: only respect `pager.tag` in list-mode Message-ID: <20170803192947.7x5tadwb7lxermdk@sigill.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 02, 2017 at 09:40:48PM +0200, Martin Ågren wrote: > This is the third version of my attempt to make `pager tag` useful (v1 > at [1], v2 at [2]). Thanks to Junio and Peff for comments on v2. This looks good to me overall. One minor question from the interdiff: > diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh > index 8b2ffb1aa..9128ec5ac 100755 > --- a/t/t7006-pager.sh > +++ b/t/t7006-pager.sh > @@ -162,7 +162,7 @@ test_expect_success TTY 'git tag with no args defaults to paging' ' > test_expect_success TTY 'git tag with no args respects pager.tag' ' > # no args implies -l so this should page like -l > rm -f paginated.out && > - test_terminal git -c pager.tag=no tag && > + test_terminal git -c pager.tag=false tag && > ! test -e paginated.out > ' These should behave the same, right? So this is just a style/consistency fix, not a bugfix? -Peff