From: Jeff King <peff@peff.net>
To: Luke Diamand <luke@diamand.org>
Cc: Stefan Beller <sbeller@google.com>,
Git Users <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>
Subject: Re: Bug in "revision.c: --all adds HEAD from all worktrees" ?
Date: Fri, 17 Nov 2017 17:03:00 -0500 [thread overview]
Message-ID: <20171117220300.5zvyjwxgi2425m7z@sigill.intra.peff.net> (raw)
In-Reply-To: <CAE5ih79TojvBv4OZnHejm3Huypg=6KVmDqJURGN+uk+izkH0xw@mail.gmail.com>
On Wed, Nov 15, 2017 at 09:38:26PM +0000, Luke Diamand wrote:
> >> Quite a few of the worktrees have expired - their head revision has
> >> been GC'd and no longer points to anything sensible
> >> (gc.worktreePruneExpire). The function other_head_refs() in worktree.c
> >> bails out if there's an error, which I think is the problem. I wonder
> >> if it should instead just report something and then keep going.
> >
> > Also see
> > https://public-inbox.org/git/CAGZ79kYP0z1G_H3nwfmSHraWHMBOcik5LepUXKj0nveeBrihiw@mail.gmail.com/
>
> So is this a bug or user error on my part?
It's a bug. You didn't do anything wrong, but the worktree feature
corrupted your repository.
-Peff
next prev parent reply other threads:[~2017-11-17 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 19:51 Bug in "revision.c: --all adds HEAD from all worktrees" ? Luke Diamand
2017-11-13 22:03 ` Luke Diamand
2017-11-13 22:15 ` Stefan Beller
2017-11-15 21:38 ` Luke Diamand
2017-11-17 22:03 ` Jeff King [this message]
2017-11-15 22:08 ` Junio C Hamano
2017-11-16 1:06 ` Luke Diamand
2018-03-12 21:39 ` Ævar Arnfjörð Bjarmason
2018-03-13 11:22 ` Duy Nguyen
2018-03-13 18:23 Stan Hu
2018-03-13 20:29 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117220300.5zvyjwxgi2425m7z@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).