From: Jonathan Tan <jonathantanmy@google.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v5 0/6] Partial clone part 1: object filtering
Date: Tue, 21 Nov 2017 17:37:54 -0800 [thread overview]
Message-ID: <20171121173754.12ae87e8bfdd773efada98e3@google.com> (raw)
In-Reply-To: <20171121205852.15731-1-git@jeffhostetler.com>
On Tue, 21 Nov 2017 20:58:46 +0000
Jeff Hostetler <git@jeffhostetler.com> wrote:
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Here is V5 of the list-object filtering, rev-list, and pack-objects.
>
> This version addresses comments on the V4 series. I removed the
> questionable character encoding scheme. And I removed or clarified
> use of the term "partial clone" to refer to a future feature.
>
> Jeff Hostetler (6):
> dir: allow exclusions from blob in addition to file
> oidmap: add oidmap iterator methods
> oidset: add iterator methods to oidset
> list-objects: filter objects in traverse_commit_list
> rev-list: add list-objects filtering support
> pack-objects: add list-objects filtering
I checked the diff against v4 and this looks good.
I'm still unsure if pre-parsing the --filter argument into a struct
list_objects_filter_options is the best approach API-wise in the case
that we plan to send it to the server, but it does have the benefit of
failing (and informing the user) early if the filter is in the wrong
format, so I'm fine with this patch set as-is.
next prev parent reply other threads:[~2017-11-22 1:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 20:58 [PATCH v5 0/6] Partial clone part 1: object filtering Jeff Hostetler
2017-11-21 20:58 ` [PATCH v5 1/6] dir: allow exclusions from blob in addition to file Jeff Hostetler
2017-11-21 20:58 ` [PATCH v5 2/6] oidmap: add oidmap iterator methods Jeff Hostetler
2017-11-21 20:58 ` [PATCH v5 3/6] oidset: add iterator methods to oidset Jeff Hostetler
2017-11-21 20:58 ` [PATCH v5 4/6] list-objects: filter objects in traverse_commit_list Jeff Hostetler
2017-11-22 22:56 ` Stefan Beller
2017-11-27 19:39 ` Jeff Hostetler
2017-11-30 22:03 ` Jeff King
2017-11-21 20:58 ` [PATCH v5 5/6] rev-list: add list-objects filtering support Jeff Hostetler
2017-11-22 20:08 ` Jonathan Nieder
2017-11-29 14:51 ` Jeff Hostetler
2017-11-21 20:58 ` [PATCH v5 6/6] pack-objects: add list-objects filtering Jeff Hostetler
2017-11-22 1:37 ` Jonathan Tan [this message]
2017-11-22 5:14 ` [PATCH v5 0/6] Partial clone part 1: object filtering Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121173754.12ae87e8bfdd773efada98e3@google.com \
--to=jonathantanmy@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).