From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: git@jeffhostetler.com, Stefan Beller <sbeller@google.com>
Subject: [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO
Date: Wed, 22 Nov 2017 14:38:24 -0800 [thread overview]
Message-ID: <20171122223827.26773-1-sbeller@google.com> (raw)
On reviewing [1] I wondered why there are so many asserts and wondered
if these asserts could have been prevented by a better functionality around
bug reporting in our code.
Introduce a BUG_ON macro, which is superior to assert() by
* being always there, even when compiled with NDEBUG and
* providind an additional human readable error message, like BUG()
Opinions?
Thanks,
Stefan
[1] https://public-inbox.org/git/20171121205852.15731-5-git@jeffhostetler.com/
Stefan Beller (3):
Documentation/CodingGuidelines: explain why assert is bad
git-compat: introduce BUG_ON(condition, fmt, ...) macro
contrib/coccinelle: convert all conditional bugs to bug_on
Documentation/CodingGuidelines | 3 +++
builtin/merge.c | 3 +--
contrib/coccinelle/bug_on.cocci | 8 ++++++++
environment.c | 22 ++++++++++------------
git-compat-util.h | 4 ++++
notes.c | 9 +++++----
refs.c | 7 +++----
refs/files-backend.c | 14 ++++++--------
refs/packed-backend.c | 13 +++++--------
sha1_file.c | 4 ++--
tempfile.c | 34 ++++++++++++++++------------------
usage.c | 12 +++++++++++-
12 files changed, 74 insertions(+), 59 deletions(-)
create mode 100644 contrib/coccinelle/bug_on.cocci
--
2.15.0.448.gf294e3d99a-goog
next reply other threads:[~2017-11-22 22:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 22:38 Stefan Beller [this message]
2017-11-22 22:38 ` [PATCH 1/3] Documentation/CodingGuidelines: explain why assert is bad Stefan Beller
2017-11-22 22:59 ` Jonathan Nieder
2017-11-22 23:08 ` Stefan Beller
2017-11-22 23:54 ` Jonathan Nieder
2017-11-22 22:38 ` [PATCH 2/3] git-compat: introduce BUG_ON(condition, fmt, ...) macro Stefan Beller
2017-11-22 23:02 ` Jonathan Nieder
2017-11-22 23:37 ` Jeff King
2017-11-22 22:38 ` [PATCH 3/3] contrib/coccinelle: convert all conditional bugs to bug_on Stefan Beller
2017-11-22 23:24 ` [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO Jeff King
2017-11-22 23:28 ` Jonathan Nieder
2017-11-22 23:39 ` Jeff King
2017-11-22 23:45 ` Jonathan Nieder
2017-11-22 23:58 ` Jeff King
2017-11-23 0:08 ` Jonathan Nieder
2017-11-23 0:10 ` Jeff King
2017-11-23 1:38 ` Junio C Hamano
2017-11-23 5:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122223827.26773-1-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).