From: Eric Wong <e@80x24.org>
To: Todd Zullinger <tmz@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: t9128 failing randomly with svn 1.9?
Date: Mon, 29 Jan 2018 12:06:27 +0000 [thread overview]
Message-ID: <20180129120627.al2xvx4yhhvwn6ih@untitled> (raw)
In-Reply-To: <20180129025812.GD1427@zaya.teonanacatl.net>
Todd Zullinger <tmz@pobox.com> wrote:
> brian m. carlson wrote:
> > r7 = f8467f2cee3bcead03e84cb51cf44f467a87457d (refs/remotes/origin/tags/tag3)
> > error: git-svn died of signal 11
> >
> > Doing the following three times, I had two crashes.
> >
> > (set -e; for i in $(seq 1 20); do (cd t && ./t9128-git-svn-cmd-branch.sh --verbose); done)
> >
> > I'm not really familiar with git svn or its internals, and I didn't see
> > anything recently on the list about this. Is this issue known?
The SVN bindings have been known to crash occasionally and I
can't really get my head around XS/Swig or Perl internals :/
Looking at the coredump, it seems to be around exit and
destruction (only Perl in the stacktrace, nothing from libsvn).
So I suspect it's a lifetime or ordering bug, testing a patch
below (slowly).
"branch" is also the only place we use SVN::Client->new these
days.
> For me, it's tests 3 and 4 which fail with the same error.
> I thought it was a failure in subversion or the perl
> bindings rather than git, so I simply disabled them in the
> Fedora builds. The Debian packages skip 9128 as well (and
> 9167, which fails similarly).
>
> I've seen the failures in t9141 from 'git svn branch' as
> well. I made a note to re-enable those tests after Jeff's
> work to make it easier to run with shell tracing enabled by
> default, but have not done so yet.
Just a guess, but it might be related to destruction order.
Running t9128 on a 32-bit Pentium-M, it took me 39 tries to
fail.
diff --git a/git-svn.perl b/git-svn.perl
index 76a75d0b3d..2ba14269bb 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1200,6 +1200,11 @@ sub cmd_branch {
$ctx->copy($src, $rev, $dst)
unless $_dry_run;
+ # Release resources held by ctx before creating another SVN::Ra
+ # so destruction is orderly. This seems necessary Subversion 1.9.5
+ # to avoid segfaults.
+ $ctx = undef;
+
$gs->fetch_all;
}
I'll be looping t9128, t9141 and t9167 with that for a few
hours or day. Will report back sooner if it fails.
I'm on an ancient 32-bit system, I guess you guys encountered
it on 64-bit machines?
next prev parent reply other threads:[~2018-01-29 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 1:51 t9128 failing randomly with svn 1.9? brian m. carlson
2018-01-29 2:58 ` Todd Zullinger
2018-01-29 12:06 ` Eric Wong [this message]
2018-01-29 18:43 ` Todd Zullinger
2018-01-29 23:16 ` [PATCH] git-svn: control destruction order to avoid segfault Eric Wong
2018-01-30 21:15 ` Junio C Hamano
2018-01-30 0:25 ` t9128 failing randomly with svn 1.9? brian m. carlson
2018-01-30 3:09 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129120627.al2xvx4yhhvwn6ih@untitled \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).