From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Lars Schneider <larsxschneider@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Duy Nguyen <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCHv2 0/5] Travis CI: don't run the test suite as root in the 32 bit Linux build
Date: Mon, 29 Jan 2018 13:23:16 -0500 [thread overview]
Message-ID: <20180129182316.GD4185@sigill.intra.peff.net> (raw)
In-Reply-To: <20180129171713.17471-1-szeder.dev@gmail.com>
On Mon, Jan 29, 2018 at 06:17:08PM +0100, SZEDER Gábor wrote:
> This version addresses Peff comments:
>
> - Updated the commit message to discuss the broken && chain and its
> consequences in patch 2.
> - Fixed quoting of the 'su' command snippet and updated the commit
> message in patch 3.
> - Squelch error from 'test "$(id -u $CI_USER)"' and add debug
> message in patch 5.
>
> Additionally, it's rebased onto current master (I branched off v1 from
> 'sg/travis-build-during-script-phase' to avoid a conflict, but Junio
> applied it on top of current master).
Thanks, this all looks good to me.
-Peff
prev parent reply other threads:[~2018-01-29 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 17:17 [PATCHv2 0/5] Travis CI: don't run the test suite as root in the 32 bit Linux build SZEDER Gábor
2018-01-29 17:17 ` [PATCHv2 1/5] travis-ci: use 'set -x' for the commands under 'su' " SZEDER Gábor
2018-01-29 17:17 ` [PATCHv2 2/5] travis-ci: use 'set -e' in the 32 bit Linux build job SZEDER Gábor
2018-01-29 17:17 ` [PATCHv2 3/5] travis-ci: don't repeat the path of the cache directory SZEDER Gábor
2018-01-29 17:17 ` [PATCHv2 4/5] travis-ci: don't run the test suite as root in the 32 bit Linux build SZEDER Gábor
2018-01-29 17:17 ` [PATCHv2 5/5] travis-ci: don't fail if user already exists on 32 bit Linux build job SZEDER Gábor
2018-01-29 18:23 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129182316.GD4185@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=pclouds@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).