From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Brandon Williams <bmwill@google.com>,
Stefan Beller <sbeller@google.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH 2/2] Revert "repository: pre-initialize hash algo pointer"
Date: Fri, 23 Feb 2018 22:29:50 +0000 [thread overview]
Message-ID: <20180223222950.GK6619@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20180223095640.25876-3-pclouds@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]
On Fri, Feb 23, 2018 at 04:56:40PM +0700, Nguyễn Thái Ngọc Duy wrote:
> diff --git a/builtin/index-pack.c b/builtin/index-pack.c
> index 7e3e1a461c..8ee935504e 100644
> --- a/builtin/index-pack.c
> +++ b/builtin/index-pack.c
> @@ -1673,6 +1673,11 @@ int cmd_index_pack(int argc, const char **argv, const char *prefix)
> if (prefix && chdir(prefix))
> die(_("Cannot come back to cwd"));
>
> + if (!the_hash_algo) {
> + warning(_("Running without a repository, assuming SHA-1 hash"));
> + repo_set_hash_algo(the_repository, GIT_HASH_SHA1);
> + }
Is this warning going to be visible to users in the normal course of
operation? If so, people are probably going to find this bothersome or
alarming.
> for (i = 1; i < argc; i++) {
> const char *arg = argv[i];
>
> diff --git a/common-main.c b/common-main.c
> index 6a689007e7..12aec36794 100644
> --- a/common-main.c
> +++ b/common-main.c
> @@ -1,6 +1,7 @@
> #include "cache.h"
> #include "exec_cmd.h"
> #include "attr.h"
> +#include "repository.h"
>
> /*
> * Many parts of Git have subprograms communicate via pipe, expect the
> @@ -40,5 +41,8 @@ int main(int argc, const char **argv)
>
> restore_sigpipe_to_default();
>
> + if (getenv("GIT_HASH_FIXUP"))
> + repo_set_hash_algo(the_repository, GIT_HASH_SHA1);
I'm lukewarm on adding this environment variable, but considering our
history here, we had probably better. We can always remove it after a
few releases.
> return cmd_main(argc, argv);
> }
> diff --git a/diff-no-index.c b/diff-no-index.c
> index 0ed5f0f496..f038f665bc 100644
> --- a/diff-no-index.c
> +++ b/diff-no-index.c
> @@ -241,6 +241,11 @@ void diff_no_index(struct rev_info *revs,
> struct strbuf replacement = STRBUF_INIT;
> const char *prefix = revs->prefix;
>
> + if (!the_hash_algo) {
> + warning(_("Running without a repository, assuming SHA-1 hash"));
> + repo_set_hash_algo(the_repository, GIT_HASH_SHA1);
> + }
Again, same concern. I can imagine scripts that will blow up loudly if
git diff --no-index spews things to standard error.
I'm not opposed to making this more visible, but I wonder if maybe it
should only be visible to developers or such. The only way I can think
of doing is that is with an advice options, but maybe there's a better
way.
--
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
next prev parent reply other threads:[~2018-02-23 22:30 UTC|newest]
Thread overview: 239+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 1:22 [PATCH 00/26] Moving global state into the repository object (part 1) Stefan Beller
2018-02-13 1:22 ` [PATCH 01/26] repository: introduce raw object store field Stefan Beller
2018-02-13 1:22 ` [PATCH 02/26] object-store: move alt_odb_list and alt_odb_tail to object store Stefan Beller
2018-02-13 18:51 ` Brandon Williams
2018-02-13 19:46 ` Stefan Beller
2018-02-13 1:22 ` [PATCH 03/26] object-store: free alt_odb_list Stefan Beller
2018-02-13 1:22 ` [PATCH 04/26] object-store: move packed_git and packed_git_mru to object store Stefan Beller
2018-02-13 1:22 ` [PATCH 05/26] object-store: close all packs upon clearing the " Stefan Beller
2018-02-13 1:22 ` [PATCH 06/26] pack: move prepare_packed_git_run_once to " Stefan Beller
2018-02-13 1:22 ` [PATCH 07/26] pack: move approximate object count " Stefan Beller
2018-02-13 1:22 ` [PATCH 08/26] sha1_file: add raw_object_store argument to alt_odb_usable Stefan Beller
2018-02-13 1:22 ` [PATCH 09/26] sha1_file: add repository argument to link_alt_odb_entry Stefan Beller
2018-02-13 1:22 ` [PATCH 10/26] sha1_file: add repository argument to read_info_alternates Stefan Beller
2018-02-13 1:22 ` [PATCH 11/26] sha1_file: add repository argument to link_alt_odb_entries Stefan Beller
2018-02-13 1:22 ` [PATCH 12/26] sha1_file: add repository argument to prepare_alt_odb Stefan Beller
2018-02-13 1:22 ` [PATCH 13/26] sha1_file: allow link_alt_odb_entries to handle arbitrary repositories Stefan Beller
2018-02-13 1:22 ` [PATCH 14/26] sha1_file: allow prepare_alt_odb " Stefan Beller
2018-02-14 0:37 ` Duy Nguyen
2018-02-14 18:08 ` Brandon Williams
2018-02-23 9:56 ` [PATCH 0/2] Fix initializing the_hash_algo Nguyễn Thái Ngọc Duy
2018-02-23 9:56 ` [PATCH 1/2] setup.c: initialize the_repository correctly in all cases Nguyễn Thái Ngọc Duy
2018-02-23 22:17 ` brian m. carlson
2018-02-24 3:17 ` Duy Nguyen
2018-02-23 9:56 ` [PATCH 2/2] Revert "repository: pre-initialize hash algo pointer" Nguyễn Thái Ngọc Duy
2018-02-23 18:24 ` Stefan Beller
2018-02-23 19:50 ` Junio C Hamano
2018-02-23 20:04 ` Stefan Beller
2018-02-23 22:26 ` Junio C Hamano
2018-02-23 22:29 ` brian m. carlson [this message]
2018-02-23 23:16 ` Brandon Williams
2018-02-24 3:44 ` Duy Nguyen
2018-02-26 23:09 ` Junio C Hamano
2018-03-03 1:51 ` Duy Nguyen
2018-02-23 22:47 ` [PATCH 0/2] Fix initializing the_hash_algo brian m. carlson
2018-02-24 3:34 ` [PATCH v2 0/5] " Nguyễn Thái Ngọc Duy
2018-02-24 3:34 ` [PATCH v2 1/5] setup.c: initialize the_repository correctly in all cases Nguyễn Thái Ngọc Duy
2018-02-24 3:34 ` [PATCH v2 2/5] sha1_file.c: keep a good name for "unknown" hash_algos[UNKNOWN] Nguyễn Thái Ngọc Duy
2018-02-24 22:39 ` brian m. carlson
2018-02-24 3:34 ` [PATCH v2 3/5] index-pack: check (and optionally set) hash algo based on input file Nguyễn Thái Ngọc Duy
2018-02-24 22:56 ` brian m. carlson
2018-02-24 3:34 ` [PATCH v2 4/5] diff.c: initialize hash algo when running in --no-index mode Nguyễn Thái Ngọc Duy
2018-02-24 8:15 ` Eric Sunshine
2018-02-24 13:45 ` Duy Nguyen
2018-02-24 14:36 ` Duy Nguyen
2018-02-24 22:29 ` brian m. carlson
2018-02-24 3:34 ` [PATCH v2 5/5] Revert "repository: pre-initialize hash algo pointer" Nguyễn Thái Ngọc Duy
2018-02-24 22:58 ` brian m. carlson
2018-02-25 3:29 ` Duy Nguyen
2018-02-25 20:28 ` brian m. carlson
2018-02-25 11:18 ` [PATCH v3 0/6] Fix initializing the_hash_algo Nguyễn Thái Ngọc Duy
2018-02-25 11:18 ` [PATCH v3 1/6] setup.c: initialize the_repository correctly in all cases Nguyễn Thái Ngọc Duy
2018-02-25 11:18 ` [PATCH v3 2/6] sha1_file.c: keep a good name for "unknown" hash_algos[UNKNOWN] Nguyễn Thái Ngọc Duy
2018-02-25 11:18 ` [PATCH v3 3/6] cache.h: make the_hash_algo read-only Nguyễn Thái Ngọc Duy
2018-02-25 11:18 ` [PATCH v3 4/6] index-pack: check (and optionally set) hash algo based on input file Nguyễn Thái Ngọc Duy
2018-02-25 11:18 ` [PATCH v3 5/6] diff.c: initialize hash algo when running in --no-index mode Nguyễn Thái Ngọc Duy
2018-02-25 11:18 ` [PATCH v3 6/6] Revert "repository: pre-initialize hash algo pointer" Nguyễn Thái Ngọc Duy
2018-02-25 20:34 ` [PATCH v3 0/6] Fix initializing the_hash_algo brian m. carlson
2018-02-26 19:20 ` Stefan Beller
2018-02-26 10:30 ` [PATCH 0/4] Delete ignore_env member in struct repository Nguyễn Thái Ngọc Duy
2018-02-26 10:30 ` [PATCH 1/4] repository.c: move env-related setup code back to environment.c Nguyễn Thái Ngọc Duy
2018-02-26 18:57 ` Eric Sunshine
2018-02-27 9:11 ` Duy Nguyen
2018-02-27 9:39 ` Duy Nguyen
2018-02-26 20:30 ` Stefan Beller
2018-02-27 0:28 ` Duy Nguyen
2018-02-26 10:30 ` [PATCH 2/4] repository.c: delete dead functions Nguyễn Thái Ngọc Duy
2018-02-26 10:30 ` [PATCH 3/4] sha1_file.c: move delayed getenv(altdb) back to setup_git_env() Nguyễn Thái Ngọc Duy
2018-02-26 10:30 ` [PATCH 4/4] repository: delete ignore_env member Nguyễn Thái Ngọc Duy
2018-02-26 18:07 ` [PATCH 0/4] Delete ignore_env member in struct repository Junio C Hamano
2018-02-26 20:46 ` Stefan Beller
2018-02-27 0:18 ` Duy Nguyen
2018-02-27 9:58 ` [PATCH v2 " Nguyễn Thái Ngọc Duy
2018-02-27 9:58 ` [PATCH v2 1/4] repository.c: move env-related setup code back to environment.c Nguyễn Thái Ngọc Duy
2018-02-27 20:09 ` Brandon Williams
2018-02-27 9:58 ` [PATCH v2 2/4] repository.c: delete dead functions Nguyễn Thái Ngọc Duy
2018-02-27 20:10 ` Brandon Williams
2018-02-27 9:58 ` [PATCH v2 3/4] sha1_file.c: move delayed getenv(altdb) back to setup_git_env() Nguyễn Thái Ngọc Duy
2018-02-27 20:12 ` Brandon Williams
2018-02-28 0:58 ` Duy Nguyen
2018-02-27 9:58 ` [PATCH v2 4/4] repository: delete ignore_env member Nguyễn Thái Ngọc Duy
2018-02-27 20:14 ` Brandon Williams
2018-02-27 10:10 ` [PATCH v2 0/4] Delete ignore_env member in struct repository Eric Sunshine
2018-02-27 18:09 ` Stefan Beller
2018-02-28 1:37 ` [PATCH v3 " Nguyễn Thái Ngọc Duy
2018-02-28 1:37 ` [PATCH v3 1/4] repository.c: move env-related setup code back to environment.c Nguyễn Thái Ngọc Duy
2018-02-28 1:37 ` [PATCH v3 2/4] repository.c: delete dead functions Nguyễn Thái Ngọc Duy
2018-02-28 1:37 ` [PATCH v3 3/4] sha1_file.c: move delayed getenv(altdb) back to setup_git_env() Nguyễn Thái Ngọc Duy
2018-02-28 1:37 ` [PATCH v3 4/4] repository: delete ignore_env member Nguyễn Thái Ngọc Duy
2018-02-28 18:12 ` [PATCH v3 0/4] Delete ignore_env member in struct repository Brandon Williams
2018-02-28 18:57 ` Junio C Hamano
2018-02-13 1:22 ` [PATCH 15/26] sha1_file: add repository argument to sha1_file_name Stefan Beller
2018-02-13 1:22 ` [PATCH 16/26] sha1_file: add repository argument to stat_sha1_file Stefan Beller
2018-02-13 1:22 ` [PATCH 17/26] sha1_file: add repository argument to open_sha1_file Stefan Beller
2018-02-13 1:22 ` [PATCH 18/26] sha1_file: add repository argument to map_sha1_file_1 Stefan Beller
2018-02-13 1:22 ` [PATCH 19/26] sha1_file: add repository argument to map_sha1_file Stefan Beller
2018-02-13 1:22 ` [PATCH 20/26] sha1_file: add repository argument to sha1_loose_object_info Stefan Beller
2018-02-13 1:22 ` [PATCH 21/26] sha1_file: allow sha1_file_name to handle arbitrary repositories Stefan Beller
2018-02-13 1:22 ` [PATCH 22/26] sha1_file: allow stat_sha1_file " Stefan Beller
2018-02-13 1:22 ` [PATCH 23/26] sha1_file: allow open_sha1_file " Stefan Beller
2018-02-13 1:22 ` [PATCH 24/26] sha1_file: allow map_sha1_file_1 " Stefan Beller
2018-02-13 1:22 ` [PATCH 25/26] sha1_file: allow map_sha1_file " Stefan Beller
2018-02-13 1:22 ` [PATCH 26/26] sha1_file: allow sha1_loose_object_info " Stefan Beller
2018-02-13 1:38 ` [PATCH 00/26] Moving global state into the repository object (part 1) Stefan Beller
2018-02-13 11:49 ` Duy Nguyen
2018-02-13 12:13 ` Duy Nguyen
2018-02-13 16:52 ` Brandon Williams
2018-02-13 17:47 ` Stefan Beller
2018-02-13 18:57 ` Junio C Hamano
2018-02-13 19:23 ` Stefan Beller
2018-02-13 19:35 ` Junio C Hamano
2018-02-13 19:43 ` Stefan Beller
2018-02-14 0:30 ` Junio C Hamano
2018-02-13 19:26 ` Jonathan Nieder
2018-02-14 0:57 ` Duy Nguyen
2018-02-13 19:33 ` Brandon Williams
2018-02-15 20:42 ` Junio C Hamano
2018-02-15 21:09 ` Stefan Beller
2018-02-16 17:46 ` [PATCHv2 00/16] " Stefan Beller
2018-02-16 17:46 ` [PATCH 01/16] repository: introduce raw object store field Stefan Beller
2018-02-16 17:46 ` [PATCH 02/16] object-store: move alt_odb_list and alt_odb_tail to object store Stefan Beller
2018-02-16 17:46 ` [PATCH 03/16] object-store: free alt_odb_list Stefan Beller
2018-02-16 17:46 ` [PATCH 04/16] object-store: move packed_git and packed_git_mru to object store Stefan Beller
2018-02-16 20:27 ` Junio C Hamano
2018-02-16 17:46 ` [PATCH 05/16] object-store: close all packs upon clearing the " Stefan Beller
2018-02-16 17:46 ` [PATCH 06/16] pack: move prepare_packed_git_run_once to " Stefan Beller
2018-02-16 17:46 ` [PATCH 07/16] pack: move approximate object count " Stefan Beller
2018-02-16 17:46 ` [PATCH 08/16] sha1_file: add raw_object_store argument to alt_odb_usable Stefan Beller
2018-02-16 17:46 ` [PATCH 09/16] sha1_file: allow link_alt_odb_entries to handle arbitrary object stores Stefan Beller
2018-02-16 17:46 ` [PATCH 10/16] sha1_file: allow prepare_alt_odb " Stefan Beller
2018-02-16 17:46 ` [PATCH 11/16] sha1_file: allow sha1_file_name " Stefan Beller
2018-02-16 17:46 ` [PATCH 12/16] sha1_file: allow stat_sha1_file " Stefan Beller
2018-02-16 17:46 ` [PATCH 13/16] sha1_file: allow open_sha1_file " Stefan Beller
2018-02-16 17:46 ` [PATCH 14/16] sha1_file: allow map_sha1_file_1 " Stefan Beller
2018-02-16 17:46 ` [PATCH 15/16] sha1_file: allow map_sha1_file " Stefan Beller
2018-02-16 17:46 ` [PATCH 16/16] sha1_file: allow sha1_loose_object_info " Stefan Beller
2018-02-16 22:34 ` [PATCHv2 00/16] Moving global state into the repository object (part 1) Jonathan Nieder
2018-02-20 18:55 ` Stefan Beller
2018-02-20 19:00 ` Brandon Williams
2018-02-20 19:03 ` Stefan Beller
2018-02-20 19:03 ` Junio C Hamano
2018-02-20 19:06 ` Stefan Beller
2018-02-20 19:55 ` Junio C Hamano
2018-02-20 20:16 ` Stefan Beller
2018-02-21 1:54 ` [PATCHv3 00/27] " Stefan Beller
2018-02-21 1:54 ` [PATCH 01/27] repository: introduce raw object store field Stefan Beller
2018-02-22 6:26 ` Jonathan Nieder
2018-02-21 1:54 ` [PATCH 02/27] object-store: migrate alternates struct and functions from cache.h Stefan Beller
2018-02-22 0:37 ` Brandon Williams
2018-02-21 1:54 ` [PATCH 03/27] object-store: move alt_odb_list and alt_odb_tail to object store Stefan Beller
2018-02-22 0:41 ` Brandon Williams
2018-02-21 1:54 ` [PATCH 04/27] object-store: free alt_odb_list Stefan Beller
2018-02-22 0:42 ` Brandon Williams
2018-02-21 1:54 ` [PATCH 05/27] object-store: move packed_git and packed_git_mru to object store Stefan Beller
2018-02-21 21:51 ` Junio C Hamano
2018-02-23 20:01 ` Stefan Beller
2018-02-22 6:44 ` Jonathan Nieder
2018-02-23 21:42 ` Stefan Beller
2018-02-21 1:54 ` [PATCH 06/27] object-store: close all packs upon clearing the " Stefan Beller
2018-02-22 0:43 ` Brandon Williams
2018-02-21 1:54 ` [PATCH 07/27] pack: move prepare_packed_git_run_once to " Stefan Beller
2018-02-22 0:20 ` Jonathan Tan
2018-02-21 1:54 ` [PATCH 08/27] pack: move approximate object count " Stefan Beller
2018-02-22 0:47 ` Brandon Williams
2018-02-23 22:22 ` Stefan Beller
2018-02-26 8:55 ` Jeff King
2018-02-26 20:57 ` Stefan Beller
2018-02-21 1:54 ` [PATCH 09/27] sha1_file: add raw_object_store argument to alt_odb_usable Stefan Beller
2018-02-22 0:29 ` Jonathan Tan
2018-02-21 1:54 ` [PATCH 10/27] sha1_file: add repository argument to link_alt_odb_entry Stefan Beller
2018-02-21 1:54 ` [PATCH 11/27] sha1_file: add repository argument to read_info_alternates Stefan Beller
2018-02-21 1:54 ` [PATCH 12/27] sha1_file: add repository argument to link_alt_odb_entries Stefan Beller
2018-02-21 1:54 ` [PATCH 13/27] sha1_file: add repository argument to prepare_alt_odb Stefan Beller
2018-02-22 6:51 ` Jonathan Nieder
2018-02-23 22:33 ` Stefan Beller
2018-02-21 1:54 ` [PATCH 14/27] sha1_file: allow link_alt_odb_entries to handle arbitrary repositories Stefan Beller
2018-02-22 0:49 ` Brandon Williams
2018-02-21 1:54 ` [PATCH 15/27] sha1_file: allow prepare_alt_odb " Stefan Beller
2018-02-22 0:35 ` Jonathan Tan
2018-02-23 23:18 ` Stefan Beller
2018-02-21 1:54 ` [PATCH 16/27] sha1_file: add repository argument to sha1_file_name Stefan Beller
2018-02-22 0:51 ` Brandon Williams
2018-02-23 22:36 ` Stefan Beller
2018-02-23 23:11 ` Brandon Williams
2018-02-21 1:54 ` [PATCH 17/27] sha1_file: add repository argument to stat_sha1_file Stefan Beller
2018-02-22 6:52 ` Jonathan Nieder
2018-02-21 1:54 ` [PATCH 18/27] sha1_file: add repository argument to open_sha1_file Stefan Beller
2018-02-21 1:54 ` [PATCH 19/27] sha1_file: add repository argument to map_sha1_file_1 Stefan Beller
2018-02-22 0:36 ` Jonathan Tan
2018-02-21 1:54 ` [PATCH 20/27] sha1_file: add repository argument to map_sha1_file Stefan Beller
2018-02-21 1:54 ` [PATCH 21/27] sha1_file: add repository argument to sha1_loose_object_info Stefan Beller
2018-02-22 6:53 ` Jonathan Nieder
2018-02-21 1:54 ` [PATCH 22/27] sha1_file: allow sha1_file_name to handle arbitrary repositories Stefan Beller
2018-02-22 0:44 ` Jonathan Tan
2018-02-23 22:50 ` Stefan Beller
2018-02-21 1:54 ` [PATCH 23/27] sha1_file: allow stat_sha1_file " Stefan Beller
2018-02-21 1:54 ` [PATCH 24/27] sha1_file: allow open_sha1_file " Stefan Beller
2018-02-22 0:45 ` Jonathan Tan
2018-02-21 1:54 ` [PATCH 25/27] sha1_file: allow map_sha1_file_1 " Stefan Beller
2018-02-21 1:54 ` [PATCH 26/27] sha1_file: allow map_sha1_file " Stefan Beller
2018-02-22 6:54 ` Jonathan Nieder
2018-02-21 1:54 ` [PATCH 27/27] sha1_file: allow sha1_loose_object_info " Stefan Beller
2018-02-22 0:26 ` [PATCHv3 00/27] Moving global state into the repository object (part 1) Stefan Beller
2018-02-24 0:47 ` [PATCHv4 " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 01/27] repository: introduce raw object store field Stefan Beller
2018-02-26 9:30 ` Duy Nguyen
2018-02-26 18:19 ` Junio C Hamano
2018-02-26 18:23 ` Brandon Williams
2018-02-26 19:28 ` Stefan Beller
2018-02-26 23:59 ` Duy Nguyen
2018-02-24 0:47 ` [PATCHv4 02/27] object-store: migrate alternates struct and functions from cache.h Stefan Beller
2018-02-24 0:47 ` [PATCHv4 03/27] object-store: move alt_odb_list and alt_odb_tail to object store Stefan Beller
2018-02-24 0:47 ` [PATCHv4 04/27] object-store: free alt_odb_list Stefan Beller
2018-02-24 0:47 ` [PATCHv4 05/27] object-store: move packed_git and packed_git_mru to object store Stefan Beller
2018-02-24 0:47 ` [PATCHv4 06/27] object-store: close all packs upon clearing the " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 07/27] pack: move prepare_packed_git_run_once to " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 08/27] pack: move approximate object count " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 09/27] sha1_file: add raw_object_store argument to alt_odb_usable Stefan Beller
2018-02-24 0:47 ` [PATCHv4 10/27] sha1_file: add repository argument to link_alt_odb_entry Stefan Beller
2018-02-24 0:47 ` [PATCHv4 11/27] sha1_file: add repository argument to read_info_alternates Stefan Beller
2018-02-24 0:47 ` [PATCHv4 12/27] sha1_file: add repository argument to link_alt_odb_entries Stefan Beller
2018-02-24 0:47 ` [PATCHv4 13/27] sha1_file: add repository argument to prepare_alt_odb Stefan Beller
2018-02-24 0:47 ` [PATCHv4 14/27] sha1_file: allow link_alt_odb_entries to handle arbitrary repositories Stefan Beller
2018-02-24 0:47 ` [PATCHv4 15/27] sha1_file: allow prepare_alt_odb " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 16/27] sha1_file: add repository argument to sha1_file_name Stefan Beller
2018-02-24 0:47 ` [PATCHv4 17/27] sha1_file: add repository argument to stat_sha1_file Stefan Beller
2018-02-24 0:47 ` [PATCHv4 18/27] sha1_file: add repository argument to open_sha1_file Stefan Beller
2018-02-24 0:47 ` [PATCHv4 19/27] sha1_file: add repository argument to map_sha1_file_1 Stefan Beller
2018-02-24 0:47 ` [PATCHv4 20/27] sha1_file: add repository argument to map_sha1_file Stefan Beller
2018-02-24 0:47 ` [PATCHv4 21/27] sha1_file: add repository argument to sha1_loose_object_info Stefan Beller
2018-02-24 0:47 ` [PATCHv4 22/27] sha1_file: allow sha1_file_name to handle arbitrary repositories Stefan Beller
2018-02-24 0:47 ` [PATCHv4 23/27] sha1_file: allow stat_sha1_file " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 24/27] sha1_file: allow open_sha1_file " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 25/27] sha1_file: allow map_sha1_file_1 " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 26/27] sha1_file: allow map_sha1_file " Stefan Beller
2018-02-24 0:47 ` [PATCHv4 27/27] sha1_file: allow sha1_loose_object_info " Stefan Beller
2018-02-24 15:00 ` [PATCHv4 00/27] Moving global state into the repository object (part 1) Duy Nguyen
2018-02-26 20:50 ` Stefan Beller
2018-02-27 0:02 ` Duy Nguyen
2018-02-26 18:19 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223222950.GK6619@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).