From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 684A01F404 for ; Wed, 18 Apr 2018 22:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699AbeDRWgy (ORCPT ); Wed, 18 Apr 2018 18:36:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53822 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbeDRWgw (ORCPT ); Wed, 18 Apr 2018 18:36:52 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5B7116076A; Wed, 18 Apr 2018 22:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524091012; bh=OhhU7mk4mIjFelppJR0O5Wyj4sZwllOY9vsmtVySCsA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=aF1RJN/zCWNCZzyzoeKJ5kTxxr0vDYcGXlJq/5ZYWgdfqeDoDx7oJRFQSkclOBfir 6tQLxDtLzgynBxpHug94YcmK5H0n/fn8t59zNYEee0ruhqFgJS9RvM3vti/5GIeoku KLv3tJItEoVgozk65ZfUi3nJt6Q0ue+V5YlCrQHM= Received: from localhost.localdomain (unknown [188.27.164.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: eddy.petrisor@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BD66560500; Wed, 18 Apr 2018 22:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1524091012; bh=OhhU7mk4mIjFelppJR0O5Wyj4sZwllOY9vsmtVySCsA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=aF1RJN/zCWNCZzyzoeKJ5kTxxr0vDYcGXlJq/5ZYWgdfqeDoDx7oJRFQSkclOBfir 6tQLxDtLzgynBxpHug94YcmK5H0n/fn8t59zNYEee0ruhqFgJS9RvM3vti/5GIeoku KLv3tJItEoVgozk65ZfUi3nJt6Q0ue+V5YlCrQHM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BD66560500 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=eddy.petrisor@codeaurora.org From: =?UTF-8?q?Eddy=20Petri=C8=99or?= To: sbeller@google.com, jrnieder@gmail.com Cc: =?UTF-8?q?Eddy=20Petri=C8=99or?= , git@vger.kernel.org Subject: [RFC PATCH v4 3/9] fixup:t7406: use test_commit instead of echo/add/commit as suggested by Stefan Beller Date: Thu, 19 Apr 2018 01:35:46 +0300 Message-Id: <20180418223552.18345-3-eddy.petrisor@codeaurora.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180418223552.18345-1-eddy.petrisor@codeaurora.org> References: <20180418223552.18345-1-eddy.petrisor@codeaurora.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Eddy Petrișor Signed-off-by: Eddy Petrișor --- t/t7406-submodule-update.sh | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh index 7b65f1dd1..7fb370991 100755 --- a/t/t7406-submodule-update.sh +++ b/t/t7406-submodule-update.sh @@ -264,19 +264,13 @@ test_expect_success 'submodule update --remote --recursive --init should fetch m git clone super5 submodl2b2 && git clone super5 submodl1b1 && cd submodl2b2 && - echo linel2b2 > l2b2 && git checkout -b b2 && - git add l2b2 && - test_tick && - git commit -m "commit on b2 branch in l2" && + test_commit "l2_on_b2" && git rev-parse --verify HEAD >../expectl2 && git checkout master && cd ../submodl1b1 && git checkout -b b1 && - echo linel1b1 > l1b1 && - git add l1b1 && - test_tick && - git commit -m "commit on b1 branch in l1" && + test_commit "l1_on_b1" && git submodule add ../submodl2b2 submodl2b2 && git config -f .gitmodules submodule."submodl2b2".branch b2 && git add .gitmodules && @@ -286,10 +280,7 @@ test_expect_success 'submodule update --remote --recursive --init should fetch m git rev-parse --verify HEAD >../expectl1 && git checkout master && cd ../super5 && - echo super_with_2_chained_modules > super5 && - git add super5 && - test_tick && - git commit -m "commit on default branch in super5" && + test_commit super5_with_2_chained_modules_on_default_branch && git submodule add ../submodl1b1 submodl1b1 && git config -f .gitmodules submodule."submodl1b1".branch b1 && git add .gitmodules && -- 2.16.2