git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Ruderich <simon@ruderich.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Git Mailing List <git@vger.kernel.org>,
	Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Subject: Re: Silly "git gc" UI issue.
Date: Fri, 20 Apr 2018 09:27:01 +0200	[thread overview]
Message-ID: <20180420072701.GB13462@ruderich.org> (raw)
In-Reply-To: <xmqqh8o7eq7j.fsf@gitster-ct.c.googlers.com>

On Thu, Apr 19, 2018 at 02:10:40PM +0900, Junio C Hamano wrote:
> diff --git a/parse-options-cb.c b/parse-options-cb.c
> index c6679cb2cd..872627eafe 100644
> --- a/parse-options-cb.c
> +++ b/parse-options-cb.c
> @@ -38,7 +38,11 @@ int parse_opt_approxidate_cb(const struct option *opt, const char *arg,
>  int parse_opt_expiry_date_cb(const struct option *opt, const char *arg,
>  			     int unset)
>  {
> -	return parse_expiry_date(arg, (timestamp_t *)opt->value);
> +	if (unset)
> +		arg = "never";
> +	if (parse_expiry_date(arg, (timestamp_t *)opt->value))
> +		die("malformed expiration date '%s'", arg);
> +	return 0;
>  }

Should this error get translated?

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

  reply	other threads:[~2018-04-20  7:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  1:45 Silly "git gc" UI issue Linus Torvalds
2018-04-19  1:52 ` Junio C Hamano
2018-04-19  1:55   ` Junio C Hamano
2018-04-19  2:16     ` Junio C Hamano
2018-04-19  2:29       ` Linus Torvalds
2018-04-19  3:22         ` Junio C Hamano
2018-04-19  5:10         ` Junio C Hamano
2018-04-20  7:27           ` Simon Ruderich [this message]
2018-04-21  3:13             ` Junio C Hamano
2018-04-21  6:07               ` Christian Couder
2018-04-23 13:38                 ` Junio C Hamano
2018-04-19  2:19   ` Linus Torvalds
2018-04-19 10:34   ` Simon Ruderich
2018-04-20  0:14     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420072701.GB13462@ruderich.org \
    --to=simon@ruderich.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    --cc=ungureanupaulsebastian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).