From: Ben Peart <Ben.Peart@microsoft.com> To: "git@vger.kernel.org" <git@vger.kernel.org> Cc: Ben Peart <Ben.Peart@microsoft.com>, "newren@gmail.com" <newren@gmail.com>, "peff@peff.net" <peff@peff.net>, "gitster@pobox.com" <gitster@pobox.com>, "pclouds@gmail.com" <pclouds@gmail.com>, "vmiklos@frugalware.org" <vmiklos@frugalware.org>, Kevin Willford <kewillf@microsoft.com>, "Johannes.Schindelin@gmx.de" <Johannes.Schindelin@gmx.de>, "eckhard.s.maass@googlemail.com" <eckhard.s.maass@googlemail.com> Subject: [PATCH v3 3/3] merge: pass aggressive when rename detection is turned off Date: Thu, 26 Apr 2018 20:52:22 +0000 [thread overview] Message-ID: <20180426205202.23056-4-benpeart@microsoft.com> (raw) In-Reply-To: <20180426205202.23056-1-benpeart@microsoft.com> Set aggressive flag in git_merge_trees() when rename detection is turned off. This allows read_tree() to auto resolve more cases that would have otherwise been handled by the rename detection. Reviewed-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Ben Peart <benpeart@microsoft.com> --- merge-recursive.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/merge-recursive.c b/merge-recursive.c index 2637d34d87..6cc4404144 100644 --- a/merge-recursive.c +++ b/merge-recursive.c @@ -276,6 +276,7 @@ static void init_tree_desc_from_tree(struct tree_desc *desc, struct tree *tree) } static int git_merge_trees(int index_only, + int aggressive, struct tree *common, struct tree *head, struct tree *merge) @@ -294,6 +295,7 @@ static int git_merge_trees(int index_only, opts.fn = threeway_merge; opts.src_index = &the_index; opts.dst_index = &the_index; + opts.aggressive = aggressive; setup_unpack_trees_porcelain(&opts, "merge"); init_tree_desc_from_tree(t+0, common); @@ -1993,7 +1995,7 @@ int merge_trees(struct merge_options *o, return 1; } - code = git_merge_trees(o->call_depth, common, head, merge); + code = git_merge_trees(o->call_depth, !merge_detect_rename(o), common, head, merge); if (code != 0) { if (show(o, 4) || o->call_depth) -- 2.17.0.windows.1
next prev parent reply other threads:[~2018-04-26 20:52 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-20 13:36 [PATCH v1 0/2] add additional config settings for merge Ben Peart 2018-04-20 13:36 ` [PATCH v1 1/2] merge: Add merge.renames config setting Ben Peart 2018-04-20 17:02 ` Elijah Newren 2018-04-20 17:26 ` Elijah Newren 2018-04-23 12:57 ` Ben Peart 2018-04-20 17:59 ` Ben Peart 2018-04-20 18:34 ` Elijah Newren 2018-04-21 4:23 ` Junio C Hamano 2018-04-23 16:00 ` Ben Peart 2018-04-23 23:23 ` Junio C Hamano 2018-04-24 11:58 ` Johannes Schindelin 2018-04-24 17:47 ` Elijah Newren 2018-04-25 8:20 ` Johannes Schindelin 2018-04-22 12:07 ` Eckhard Maaß 2018-04-23 13:15 ` Ben Peart 2018-04-23 21:32 ` Eckhard Maaß 2018-04-24 16:53 ` Ben Peart 2018-04-23 13:22 ` Ben Peart 2018-04-20 13:36 ` [PATCH v1 2/2] merge: Add merge.aggressive " Ben Peart 2018-04-20 17:22 ` Elijah Newren 2018-04-24 16:45 ` Ben Peart 2018-04-24 17:36 ` Elijah Newren 2018-04-24 23:57 ` Junio C Hamano 2018-04-25 14:47 ` Ben Peart 2018-04-20 17:34 ` [PATCH v1 0/2] add additional config settings for merge Elijah Newren 2018-04-20 18:19 ` Ben Peart 2018-04-24 17:11 ` [PATCH v2 " Ben Peart 2018-04-24 17:11 ` [PATCH v2 1/2] merge: Add merge.renames config setting Ben Peart 2018-04-24 18:11 ` Elijah Newren 2018-04-24 18:59 ` Elijah Newren 2018-04-24 20:31 ` Ben Peart 2018-04-25 16:01 ` Elijah Newren 2018-04-24 17:11 ` [PATCH v2 2/2] merge: Add merge.aggressive " Ben Peart 2018-04-25 0:13 ` [PATCH v2 0/2] add additional config settings for merge Junio C Hamano 2018-04-25 15:22 ` Ben Peart 2018-04-26 1:48 ` Junio C Hamano 2018-04-26 20:52 ` [PATCH v3 0/3] add merge.renames config setting Ben Peart 2018-04-26 20:52 ` [PATCH v3 1/3] merge: update documentation for {merge,diff}.renameLimit Ben Peart 2018-04-26 23:11 ` Elijah Newren 2018-04-26 23:23 ` Jonathan Tan 2018-04-26 20:52 ` [PATCH v3 2/3] merge: Add merge.renames config setting Ben Peart 2018-04-26 22:52 ` Elijah Newren 2018-04-27 0:54 ` Ben Peart 2018-04-27 2:23 ` Junio C Hamano 2018-04-27 3:28 ` Elijah Newren 2018-04-27 7:23 ` Johannes Schindelin 2018-04-27 14:32 ` Elijah Newren 2018-04-27 18:37 ` Eckhard Maaß 2018-04-27 20:23 ` Elijah Newren 2018-04-30 8:03 ` Eckhard Maaß 2018-04-30 16:54 ` Elijah Newren 2018-04-27 4:17 ` Elijah Newren 2018-04-27 18:19 ` Elijah Newren 2018-04-30 13:11 ` Ben Peart 2018-04-30 16:12 ` Re: Elijah Newren 2018-05-02 14:33 ` Re: Ben Peart 2018-04-26 20:52 ` Ben Peart [this message] 2018-04-26 23:00 ` [PATCH v3 3/3] merge: pass aggressive when rename detection is turned off Elijah Newren 2018-04-26 22:08 ` [PATCH v3 0/3] add merge.renames config setting Elijah Newren 2018-05-02 16:01 ` [PATCH v4 0/3] add additional config settings for merge Ben Peart 2018-05-02 16:01 ` [PATCH v4 1/3] merge: update documentation for {merge,diff}.renameLimit Ben Peart 2018-05-02 16:01 ` [PATCH v4 2/3] merge: Add merge.renames config setting Ben Peart 2018-05-04 3:07 ` Junio C Hamano 2018-05-02 16:01 ` [PATCH v4 3/3] merge: pass aggressive when rename detection is turned off Ben Peart 2018-05-02 17:20 ` [PATCH v4 0/3] add additional config settings for merge Elijah Newren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180426205202.23056-4-benpeart@microsoft.com \ --to=ben.peart@microsoft.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=eckhard.s.maass@googlemail.com \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=kewillf@microsoft.com \ --cc=newren@gmail.com \ --cc=pclouds@gmail.com \ --cc=peff@peff.net \ --cc=vmiklos@frugalware.org \ --subject='Re: [PATCH v3 3/3] merge: pass aggressive when rename detection is turned off' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).