From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/5] snprintf truncation fixes
Date: Fri, 18 May 2018 18:54:45 -0700 [thread overview]
Message-ID: <20180519015444.GA12080@sigill.intra.peff.net> (raw)
I happened today to be looking at a piece of code that used a bare
snprintf() without checking for truncation, and I got annoyed enough to
root out the last few cases in our codebase. After this series, looking
over the results of:
git grep '[^vxn]snprintf' '*.c' :^compat
is pretty pleasant.
This series also gets rid of some uses of PATH_MAX, which is another pet
peeve of mine. :)
[1/5]: http: use strbufs instead of fixed buffers
[2/5]: log_write_email_headers: use strbufs
[3/5]: query_fsmonitor: use xsnprintf for formatting integers
[4/5]: shorten_unambiguous_ref: use xsnprintf
[5/5]: fmt_with_err: add a comment that truncation is OK
fsmonitor.c | 4 ++--
http.c | 66 +++++++++++++++++++++++++++++------------------------
http.h | 4 ++--
log-tree.c | 16 ++++++++-----
refs.c | 4 ++--
usage.c | 1 +
6 files changed, 53 insertions(+), 42 deletions(-)
-Peff
next reply other threads:[~2018-05-19 1:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 1:54 Jeff King [this message]
2018-05-19 1:56 ` [PATCH 1/5] http: use strbufs instead of fixed buffers Jeff King
2018-05-21 18:11 ` Stefan Beller
2018-05-21 19:41 ` Jeff King
2018-05-21 20:57 ` Stefan Beller
2018-05-19 1:57 ` [PATCH 2/5] log_write_email_headers: use strbufs Jeff King
2018-05-19 1:57 ` [PATCH 3/5] query_fsmonitor: use xsnprintf for formatting integers Jeff King
2018-05-19 8:27 ` René Scharfe
2018-05-20 17:08 ` Jeff King
2018-05-21 0:58 ` Junio C Hamano
2018-05-21 12:36 ` Ben Peart
2018-05-19 1:58 ` [PATCH 4/5] shorten_unambiguous_ref: use xsnprintf Jeff King
2018-05-19 1:58 ` [PATCH 5/5] fmt_with_err: add a comment that truncation is OK Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180519015444.GA12080@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).