From: Jonathan Tan <jonathantanmy@google.com>
To: gitster@pobox.com
Cc: peff@peff.net, jonathantanmy@google.com, git@vger.kernel.org
Subject: Re: [PATCH] transport: report refs only if transport does
Date: Tue, 31 Jul 2018 16:29:43 -0700 [thread overview]
Message-ID: <20180731232943.186226-1-jonathantanmy@google.com> (raw)
In-Reply-To: <xmqqa7q79jcf.fsf@gitster-ct.c.googlers.com>
> What leaves me even more confused is that the entire log message
> does not make it clear what the end-user observable problem the
> patch is trying to solve.
>
> Is this "we sometimes follow and sometimes fail to follow refs while
> fetching"? Does it affect all protocol versions and transports, or
> only just selected few (and if so which ones)?
Normally I would respond by creating a new patch with the answer in its
commit message, but I'm now not sure about whether it's better to revert
back to the non-"fetched_refs" API entirely (as I explained in the reply
to Peff I just sent [1]), so I'll answer your questions here for now:
- Yes. We fail to follow when we fetch at least one ref that is
up-to-date and one ref that is not, and when we're using the "fetch"
command in a remote helper (for example, HTTP protocol v0).
- I haven't checked exhaustively, but as far as I know, affects HTTP
protocol v0, and does not affect anything using connect or
stateless-connect (e.g. HTTP protocol v2, ssh).
When I create a new patch, I'll also include these answers in its commit
message.
[1] https://public-inbox.org/git/20180731232343.184463-1-jonathantanmy@google.com/
next prev parent reply other threads:[~2018-07-31 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 12:19 [BUG] fetching sometimes doesn't update refs Jeff King
2018-07-30 17:53 ` Brandon Williams
2018-07-30 22:56 ` [PATCH] transport: report refs only if transport does Jonathan Tan
2018-07-31 19:24 ` Jeff King
2018-07-31 21:38 ` Junio C Hamano
2018-07-31 23:29 ` Jonathan Tan [this message]
2018-07-31 23:23 ` Jonathan Tan
2018-08-01 17:18 ` Brandon Williams
2018-08-02 16:30 ` Jeff King
2018-08-01 20:13 ` [PATCH] fetch-pack: unify ref in and out param Jonathan Tan
2018-08-01 21:38 ` Brandon Williams
2018-08-01 22:23 ` Junio C Hamano
2018-08-02 16:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731232943.186226-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).