git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Han-Wen Nienhuys <hanwen@google.com>
To: gitster@pobox.com, sunshine@sunshineco.com
Cc: git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: [PATCH 1/2] config: document git config getter return value.
Date: Thu,  2 Aug 2018 14:13:07 +0200	[thread overview]
Message-ID: <20180802121308.17371-2-hanwen@google.com> (raw)
In-Reply-To: <20180802121308.17371-1-hanwen@google.com>

---
 config.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/config.h b/config.h
index b95bb7649..41700f40b 100644
--- a/config.h
+++ b/config.h
@@ -178,10 +178,16 @@ struct config_set {
 };
 
 extern void git_configset_init(struct config_set *cs);
-extern int git_configset_add_file(struct config_set *cs, const char *filename);
-extern int git_configset_get_value(struct config_set *cs, const char *key, const char **value);
+
 extern const struct string_list *git_configset_get_value_multi(struct config_set *cs, const char *key);
 extern void git_configset_clear(struct config_set *cs);
+
+/*
+ * These functions return 1 if not found, and 0 if found, leaving the found
+ * value in the 'dest' pointer.
+ */
+extern int git_configset_add_file(struct config_set *cs, const char *filename);
+extern int git_configset_get_value(struct config_set *cs, const char *key, const char **dest);
 extern int git_configset_get_string_const(struct config_set *cs, const char *key, const char **dest);
 extern int git_configset_get_string(struct config_set *cs, const char *key, char **dest);
 extern int git_configset_get_int(struct config_set *cs, const char *key, int *dest);
-- 
2.18.0.597.ga71716f1ad-goog


  reply	other threads:[~2018-08-02 12:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 12:13 [PATCH 0/2 v4] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-02 12:13 ` Han-Wen Nienhuys [this message]
2018-08-02 17:19   ` [PATCH 1/2] config: document git config getter return value Eric Sunshine
2018-08-03  3:29   ` Jonathan Nieder
2018-08-03 13:05     ` Jeff King
2018-08-03 15:57       ` Junio C Hamano
2018-08-02 12:13 ` [PATCH 2/2] sideband: highlight keywords in remote sideband output Han-Wen Nienhuys
2018-08-03  3:48   ` Eric Sunshine
2018-08-03  3:52   ` Jonathan Nieder
2018-08-06 14:17     ` Han-Wen Nienhuys
  -- strict thread matches above, loose matches on Subject: below --
2018-08-02 11:47 [PATCH 0/2 v4] " Han-Wen Nienhuys
2018-08-02 11:47 ` [PATCH 1/2] config: document git config getter return value Han-Wen Nienhuys
2018-08-02 17:37   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802121308.17371-2-hanwen@google.com \
    --to=hanwen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).