From: Jeff King <peff@peff.net>
To: Paul Smith <paul@mad-scientist.net>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: Help with "fatal: unable to read ...." error during GC?
Date: Sat, 11 Aug 2018 10:25:28 -0400 [thread overview]
Message-ID: <20180811142527.GB17605@sigill.intra.peff.net> (raw)
In-Reply-To: <20180811142341.GA17605@sigill.intra.peff.net>
On Sat, Aug 11, 2018 at 10:23:41AM -0400, Jeff King wrote:
> > I do still have these warnings and no amount of git gc/git fsck/etc.
> > has reduced them in any way:
> >
> > $ git gc
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
> > warning: reflog of 'HEAD' references pruned commits
>
> I think these would go away via "reflog expire" (I'd have thought "git
> gc" would do so, though). I wonder if this is yet another tool that
> needs to be taught about worktree heads.
>
> > I've run git gc --prune=all then git fsck reports only these dangling
> > commits:
> >
> > dangling commit cef0678a5e0765506e3fac41286696fd37a9b1e9
> > dangling commit 1729195f021a1b95ea8ca10b9c32e76bf2257e67
> > dangling commit 08385b9731291607a8c6d4bf10272002d8f31e1f
> > dangling commit c4ddfb2139eeb5a3c132dbfc84cc6e27fdeb46d1
> > dangling commit 1df8ebcc1cd5f59dd224ce1f3ba39f24370cf4e7
> >
> > (this is down from probably 50 or so "dangling ..." commits, blobs, and
> > trees before).
>
> I'd also expect "--prune=all" to drop all dangling heads. But I think
> this is the worktree thing, again. The code in fsck starts it
> connectivity check with this:
>
> if (head_points_at && !is_null_oid(&head_oid))
> fsck_handle_ref("HEAD", &head_oid, 0, NULL);
> for_each_rawref(fsck_handle_ref, NULL);
> if (include_reflogs)
> for_each_reflog(fsck_handle_reflog, NULL);
>
> but looking at the similar code in revision.c that has been upgraded to
> handle worktrees (e.g., add_reflogs_to_pending()), I think that is not
> going to look at worktree HEADs nor reflogs.
>
> I'd hoped to give you a one-liner to try out, but I think it will
> require some refactoring.
Responding myself and adding Duy to the cc to increase visibility among
worktree experts. :)
-Peff
next prev parent reply other threads:[~2018-08-11 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 14:30 Help with "fatal: unable to read ...." error during GC? Paul Smith
2018-08-08 16:06 ` Jeff King
2018-08-08 17:35 ` Paul Smith
2018-08-08 18:24 ` Jeff King
2018-08-08 21:10 ` Paul Smith
2018-08-09 2:45 ` Paul Smith
2018-08-09 17:06 ` Jeff King
2018-08-11 12:13 ` Paul Smith
2018-08-11 14:23 ` Jeff King
2018-08-11 14:25 ` Jeff King [this message]
2018-08-11 14:38 ` Duy Nguyen
2018-08-11 16:39 ` Jeff King
2018-08-12 9:29 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180811142527.GB17605@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=paul@mad-scientist.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).