From: Jeff King <peff@peff.net> To: git@vger.kernel.org Subject: [PATCH 2/6] t/perf: factor out percent calculations Date: Tue, 21 Aug 2018 15:06:45 -0400 [thread overview] Message-ID: <20180821190645.GB30764@sigill.intra.peff.net> (raw) In-Reply-To: <20180821184140.GA24165@sigill.intra.peff.net> This will let us reuse the code when we add new values to aggregate besides times. Signed-off-by: Jeff King <peff@peff.net> --- t/perf/aggregate.perl | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index bc865160e7..3181b087ab 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregate.perl @@ -19,21 +19,24 @@ sub get_times { return ($rt, $4, $5); } +sub relative_change { + my ($r, $firstr) = @_; + if ($firstr > 0) { + return sprintf "%+.1f%%", 100.0*($r-$firstr)/$firstr; + } elsif ($r == 0) { + return "="; + } else { + return "+inf"; + } +} + sub format_times { my ($r, $u, $s, $firstr) = @_; if (!defined $r) { return "<missing>"; } my $out = sprintf "%.2f(%.2f+%.2f)", $r, $u, $s; - if (defined $firstr) { - if ($firstr > 0) { - $out .= sprintf " %+.1f%%", 100.0*($r-$firstr)/$firstr; - } elsif ($r == 0) { - $out .= " ="; - } else { - $out .= " +inf"; - } - } + $out .= ' ' . relative_change($r, $firstr) if defined $firstr; return $out; } -- 2.19.0.rc0.398.g138a08f6f6
next prev parent reply other threads:[~2018-08-21 19:06 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-21 18:41 [PATCH] test-tool.h: include git-compat-util.h Jeff King 2018-08-21 19:03 ` Junio C Hamano 2018-08-21 19:06 ` [PATCH 1/6] t/perf: factor boilerplate out of test_perf Jeff King 2018-08-21 19:06 ` Jeff King [this message] 2018-08-21 19:06 ` [PATCH 3/6] t/perf: add infrastructure for measuring sizes Jeff King 2018-08-22 13:40 ` Derrick Stolee 2018-08-22 15:31 ` Jeff King 2018-08-21 19:06 ` [PATCH 4/6] t/perf: add perf tests for fetches from a bitmapped server Jeff King 2018-08-21 19:07 ` [PATCH 5/6] pack-bitmap: save "have" bitmap from walk Jeff King 2018-08-21 19:47 ` Derrick Stolee 2018-08-21 19:54 ` Jeff King 2018-08-31 15:23 ` Ævar Arnfjörð Bjarmason 2018-08-31 22:55 ` Jeff King 2018-09-01 7:41 ` [PATCH 0/4] un-breaking pack-objects with bitmaps Jeff King 2018-09-01 7:44 ` [PATCH 1/4] bitmap_has_sha1_in_uninteresting(): drop BUG check Jeff King 2018-09-01 7:48 ` [PATCH 2/4] t5310: test delta reuse with bitmaps Jeff King 2018-09-01 8:03 ` Jeff King 2018-09-01 20:29 ` Ævar Arnfjörð Bjarmason 2018-09-01 22:46 ` Ben Peart 2018-09-02 5:51 ` Jeff King 2018-09-04 19:05 ` Stefan Beller 2018-09-04 19:45 ` Junio C Hamano 2018-09-04 20:02 ` Jeff King 2018-09-01 7:49 ` [PATCH 3/4] traverse_bitmap_commit_list(): don't free result Jeff King 2018-09-01 7:50 ` [PATCH 4/4] pack-bitmap: drop "loaded" flag Jeff King 2018-09-04 19:30 ` [PATCH 0/4] un-breaking pack-objects with bitmaps Stefan Beller 2018-09-04 20:03 ` Jeff King 2018-09-08 6:43 ` Ævar Arnfjörð Bjarmason 2018-09-10 16:53 ` Junio C Hamano 2018-09-10 18:48 ` Jeff King 2018-09-10 19:23 ` Junio C Hamano 2018-08-21 19:07 ` [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects Jeff King 2018-08-21 19:43 ` Junio C Hamano 2018-08-21 19:50 ` Junio C Hamano 2018-08-21 20:07 ` Jeff King 2018-08-21 20:14 ` Jeff King 2018-08-21 20:52 ` Junio C Hamano 2018-08-21 21:30 ` Jeff King 2018-08-21 20:57 ` Junio C Hamano 2018-08-21 21:32 ` Jeff King 2018-08-23 0:43 ` [PATCH 0/9] trailer-parsing false positives Jeff King 2018-08-23 0:44 ` [PATCH 1/9] trailer: use size_t for string offsets Jeff King 2018-08-23 0:45 ` [PATCH 2/9] trailer: use size_t for iterating trailer list Jeff King 2018-08-23 0:46 ` [PATCH 3/9] trailer: pass process_trailer_opts to trailer_info_get() Jeff King 2018-08-23 0:48 ` [PATCH 4/9] interpret-trailers: tighten check for "---" patch boundary Jeff King 2018-08-23 0:49 ` [PATCH 5/9] interpret-trailers: allow suppressing "---" divider Jeff King 2018-08-23 0:50 ` [PATCH 6/9] pretty, ref-filter: format %(trailers) with no_divider option Jeff King 2018-08-23 0:50 ` [PATCH 7/9] sequencer: ignore "---" divider when parsing trailers Jeff King 2018-08-23 0:50 ` [PATCH 8/9] append_signoff: use size_t for string offsets Jeff King 2018-08-23 0:51 ` [PATCH 9/9] sequencer: handle ignore_footer when parsing trailers Jeff King 2018-08-23 18:30 ` [PATCH 0/9] trailer-parsing false positives Junio C Hamano 2018-08-24 7:26 ` Jeff King 2018-08-21 20:00 ` [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects Jeff King -- strict thread matches above, loose matches on Subject: below -- 2018-08-17 20:54 [PATCH 0/6] reuse on-disk deltas for fetches with bitmaps Jeff King 2018-08-17 20:55 ` [PATCH 2/6] t/perf: factor out percent calculations Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180821190645.GB30764@sigill.intra.peff.net \ --to=peff@peff.net \ --cc=git@vger.kernel.org \ --subject='Re: [PATCH 2/6] t/perf: factor out percent calculations' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).