From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] builtin rebase: prepare for builtin rebase -i
Date: Fri, 31 Aug 2018 16:48:32 -0400 [thread overview]
Message-ID: <20180831204832.GA14869@sigill.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1808312238250.71@tvgsbejvaqbjf.bet>
On Fri, Aug 31, 2018 at 10:38:44PM +0200, Johannes Schindelin wrote:
> > > Is there any reason why you avoid using `git rebase -ir` here? This should
> > > be so much easier via
> > >
> > > git checkout pk/rebase-i-in-c-6-final
> > > git rebase -ir js/rebase-in-c-5.5-work-with-rebase-i-in-c^
> > >
> > > and then inserting this at the appropriate position, followed by the `git
> > > range-diff @{-1}...`:
> > >
> > > git am -s mbox
> > > git update-ref js/rebase-in-c-5.5-work-with-rebase-i-in-c HEAD
> >
> > Related discussion, including a fantasy tangent by me (downthread):
> >
> > https://public-inbox.org/git/20180727080807.GA11932@sigill.intra.peff.net/#t
>
> I have no idea what you meant there...
I thought you were asking why Junio does not just use "git am" from
inside "git rebase". I asked the same thing recently, and the answer is
because he is afraid of how the two interact. I dug a little into it
(the fantasy part is that I laid out a dream for how operations like
this could safely stack).
-Peff
next prev parent reply other threads:[~2018-08-31 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 21:35 [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase Johannes Schindelin via GitGitGadget
2018-08-22 21:35 ` [PATCH 1/1] builtin rebase: prepare for builtin rebase -i Johannes Schindelin via GitGitGadget
2018-08-22 21:50 ` [PATCH 0/1] Teach the builtin rebase about the builtin interactive rebase Junio C Hamano
2018-08-23 2:48 ` Jonathan Nieder
2018-08-25 23:46 ` Johannes Schindelin
2018-08-27 17:48 ` Junio C Hamano
2018-08-28 12:53 ` Johannes Schindelin
2018-08-28 15:34 ` Junio C Hamano
2018-08-29 13:24 ` Johannes Schindelin
2018-08-28 17:17 ` Jonathan Nieder
2018-08-29 14:29 ` Johannes Schindelin
2018-08-29 14:31 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2018-08-29 14:31 ` [PATCH v2 1/1] builtin rebase: prepare for builtin rebase -i Johannes Schindelin via GitGitGadget
2018-08-29 22:40 ` Junio C Hamano
2018-08-30 11:03 ` Johannes Schindelin
2018-08-30 20:09 ` Jeff King
2018-08-31 20:38 ` Johannes Schindelin
2018-08-31 20:48 ` Jeff King [this message]
2018-10-05 15:54 ` [PATCH v3 0/1] Teach the builtin rebase about the builtin interactive rebase Johannes Schindelin via GitGitGadget
2018-10-05 15:54 ` [PATCH v3 1/1] builtin rebase: prepare for builtin rebase -i Johannes Schindelin via GitGitGadget
2018-10-06 23:50 ` [PATCH v3 0/1] Teach the builtin rebase about the builtin interactive rebase Junio C Hamano
2018-10-12 7:59 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831204832.GA14869@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).