* [PATCH] builtin/submodule--helper: remove debugging leftover tracing
@ 2018-10-16 23:45 Stefan Beller
2018-10-17 2:52 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Beller @ 2018-10-16 23:45 UTC (permalink / raw)
To: gitster; +Cc: git, Stefan Beller
I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree
by ensure-core-worktree, 2018-08-13) had two leftover debugging statements
when reading The coverage report [1]. Remove them.
https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/
Signed-off-by: Stefan Beller <sbeller@google.com>
---
To be applied on (or squashed into the tip of)
sb/submodule-update-in-c
builtin/submodule--helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 5c9d1fb496..c7d3841ffc 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1459,7 +1459,6 @@ static void determine_submodule_update_strategy(struct repository *r,
key = xstrfmt("submodule.%s.update", sub->name);
if (update) {
- trace_printf("parsing update");
if (parse_submodule_update_strategy(update, out) < 0)
die(_("Invalid update mode '%s' for submodule path '%s'"),
update, path);
@@ -1468,7 +1467,6 @@ static void determine_submodule_update_strategy(struct repository *r,
die(_("Invalid update mode '%s' configured for submodule path '%s'"),
val, path);
} else if (sub->update_strategy.type != SM_UPDATE_UNSPECIFIED) {
- trace_printf("loaded thing");
out->type = sub->update_strategy.type;
out->command = sub->update_strategy.command;
} else
--
2.19.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] builtin/submodule--helper: remove debugging leftover tracing
2018-10-16 23:45 [PATCH] builtin/submodule--helper: remove debugging leftover tracing Stefan Beller
@ 2018-10-17 2:52 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2018-10-17 2:52 UTC (permalink / raw)
To: Stefan Beller; +Cc: gitster, git
Stefan Beller wrote:
> I noticed 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree
> by ensure-core-worktree, 2018-08-13) had two leftover debugging statements
> when reading The coverage report [1]. Remove them.
>
> https://public-inbox.org/git/e30a9c05-87d8-1f2b-182c-6d6a5fefe43c@gmail.com/
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> builtin/submodule--helper.c | 2 --
> 1 file changed, 2 deletions(-)
Doh. Glad you caught it!
Is there some reference for The Coverage Report other than the mailing
list? E.g. I suspect a reference to
make coverage-test
make coverage-report
would be useful to readers finding this commit later.
> To be applied on (or squashed into the tip of)
> sb/submodule-update-in-c
Looks like that's already in "master", so not a candidate for
squashing.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-17 2:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 23:45 [PATCH] builtin/submodule--helper: remove debugging leftover tracing Stefan Beller
2018-10-17 2:52 ` Jonathan Nieder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).