From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
"GIT Mailing-list" <git@vger.kernel.org>
Subject: Re: [PATCH 2/3] ewok_rlw.h: add missing 'inline' to function definition
Date: Sat, 27 Oct 2018 02:29:09 -0400 [thread overview]
Message-ID: <20181027062909.GB16664@sigill.intra.peff.net> (raw)
In-Reply-To: <1a465da6-d139-5880-72ff-c612b42c3b8f@ramsayjones.plus.com>
On Sat, Oct 27, 2018 at 02:52:05AM +0100, Ramsay Jones wrote:
> The 'ewok_rlw.h' header file contains the rlw_get_run_bit() function
> definition, which is marked as 'static' but not 'inline'. At least when
> compiled by gcc, with the default -O2 optimization level, the function
> is actually inlined and leaves no static version in the ewah_bitmap.o
> and ewah_rlw.o object files. Despite this, add the missing 'inline'
> keyword to better describe the intended behaviour.
Yep, this makes sense. Thanks!
-Peff
prev parent reply other threads:[~2018-10-27 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 1:52 [PATCH 2/3] ewok_rlw.h: add missing 'inline' to function definition Ramsay Jones
2018-10-27 6:29 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027062909.GB16664@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).