From: nbelakovski@gmail.com
To: git@vger.kernel.org, sunshine@sunshineco.com
Cc: Nickolai Belakovski <nbelakovski@gmail.com>
Subject: [PATCH v3 1/2] worktree: update documentation for lock_reason and lock_reason_valid
Date: Mon, 29 Oct 2018 23:24:08 -0700 [thread overview]
Message-ID: <20181030062409.42169-1-nbelakovski@gmail.com> (raw)
In-Reply-To: <20181025055142.38077-1-nbelakovski@gmail.com>
From: Nickolai Belakovski <nbelakovski@gmail.com>
Clarify that these fields are to be considered implementation details
and direct the reader to use the is_worktree_locked function to retrieve
said information.
Signed-off-by: Nickolai Belakovski <nbelakovski@gmail.com>
---
worktree.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/worktree.h b/worktree.h
index df3fc30f7..6b12a3cf6 100644
--- a/worktree.h
+++ b/worktree.h
@@ -10,12 +10,12 @@ struct worktree {
char *path;
char *id;
char *head_ref; /* NULL if HEAD is broken or detached */
- char *lock_reason; /* internal use */
+ char *lock_reason; /* private - use is_worktree_locked */
struct object_id head_oid;
int is_detached;
int is_bare;
int is_current;
- int lock_reason_valid;
+ int lock_reason_valid; /* private */
};
/* Functions for acting on the information about worktrees. */
--
2.14.2
next prev parent reply other threads:[~2018-10-30 6:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 6:39 [PATCH] worktree: populate lock_reason in get_worktrees and light refactor/cleanup in worktree files nbelakovski
2018-10-24 8:11 ` Eric Sunshine
2018-10-25 5:46 ` Nickolai Belakovski
2018-10-25 5:51 ` [PATCH] worktree: refactor lock_reason_valid and lock_reason to be more sensible nbelakovski
2018-10-25 6:56 ` Junio C Hamano
2018-10-28 21:56 ` Nickolai Belakovski
2018-10-29 3:52 ` Junio C Hamano
2018-10-29 5:43 ` Nickolai Belakovski
2018-10-29 6:42 ` Junio C Hamano
[not found] ` <CAC05386cSUhBm4TLD5NUeb5Ut9GT5=h-1MvqDnFpuc+UdZFmwg@mail.gmail.com>
2018-10-28 23:02 ` Eric Sunshine
2018-10-29 1:10 ` Nickolai Belakovski
2018-10-29 4:01 ` Eric Sunshine
2018-10-29 5:45 ` Nickolai Belakovski
2018-10-29 6:21 ` Eric Sunshine
2018-10-30 6:24 ` nbelakovski [this message]
2018-10-31 2:28 ` [PATCH v3 1/2] worktree: update documentation for lock_reason and lock_reason_valid Junio C Hamano
2018-10-30 6:24 ` [PATCH v3 2/2] worktree: rename is_worktree_locked to worktree_lock_reason nbelakovski
2018-10-31 2:41 ` Junio C Hamano
2018-10-25 19:14 ` [PATCH] worktree: populate lock_reason in get_worktrees and light refactor/cleanup in worktree files Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030062409.42169-1-nbelakovski@gmail.com \
--to=nbelakovski@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).