From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: William Baker <williamtbakeremail@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
William Baker via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, stolee@gmail.com, jeffhost@microsoft.com,
William Baker <William.Baker@microsoft.com>
Subject: Re: [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip>
Date: Wed, 9 Oct 2019 02:16:40 +0200 [thread overview]
Message-ID: <20191008232439.GA7212@szeder.dev> (raw)
In-Reply-To: <202ed2c5-9729-120f-fa0e-cee9ecec3b77@gmail.com>
On Tue, Oct 08, 2019 at 09:24:56AM -0700, William Baker wrote:
> On 10/7/19 9:30 PM, Junio C Hamano wrote:
> > SZEDER Gábor <szeder.dev@gmail.com> writes:
> >
> >>> func(PROGRESS | REGRESS);
> >>> func(PROGRESS + REGRESS);
> >>> func(PROGRESS * 3);
> >>> }
> >>>
> >>> how caller came about to give 3?
> >>
> >> No, they tend to show (PROGRESS | REGRESS), at least both gdb and lldb
> >> do.
> I tried to see how lldb would handle the "PROGRESS * 3" scenario
> but I was unable to get lldb to display the "PROGRESS | REGRESS" format
> even when ORing the flags:
>
> (lldb) l 399
> 399 enum test_flags {
> 400 TEST_FLAG_1 = 1 << 0,
> 401 TEST_FLAG_2 = 1 << 1,
> 402 };
> 403
> 404 enum test_flags flags_1 = TEST_FLAG_1;
> 405 enum test_flags flags_2 = TEST_FLAG_2;
> 406 enum test_flags flags_both = TEST_FLAG_1 | TEST_FLAG_2;
> 407
> 408 if (flags_1 || flags_2 || flags_both)
> (lldb) p flags_1
> (test_flags) $0 = TEST_FLAG_1
> (lldb) p flags_2
> (test_flags) $1 = TEST_FLAG_2
> (lldb) p flags_both
> (test_flags) $2 = 3
> (lldb) fr v flags_both
> (test_flags) flags_both = 3
> (lldb) fr v --format enum flags_both
> (test_flags) flags_both = 3
> (lldb) version
> lldb-902.0.79.7
> Swift-4.1
>
> Is there something that needs to be adjusted in the config or with
> --format to display "TEST_FLAG_1 | TEST_FLAG_2" in this example?
I'm afraid you are right and lldb doesn't do this, at least not by
default, what a pity. I tried different versions of gdb and lldb,
distro-shipped older ones and some more recent in containers a couple
of days ago; now I tried it again and see the same behavior as you, so
I must have misremembered. Sorry for the confusion.
gdb still does the user-friendly thing, though.
next prev parent reply other threads:[~2019-10-09 0:16 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:37 [PATCH 0/1] multi-pack-index: add --no-progress William Baker via GitGitGadget
2019-09-11 15:37 ` [PATCH 1/1] multi-pack-index: add --no-progress Add --no-progress option to git multi-pack-index. The progress feature was added in 144d703 ("multi-pack-index: report progress during 'verify'", 2018-09-13) but the ability to opt-out was overlooked William Baker via GitGitGadget
2019-09-12 20:17 ` Junio C Hamano
2019-09-13 18:45 ` William Baker
2019-09-13 20:26 ` Junio C Hamano
2019-09-16 19:49 ` William Baker
2019-09-11 20:30 ` [PATCH 0/1] multi-pack-index: add --no-progress Derrick Stolee
2019-09-20 16:53 ` [PATCH v2 0/6] " William Baker via GitGitGadget
2019-09-20 16:53 ` [PATCH v2 1/6] midx: add MIDX_PROGRESS flag Add the MIDX_PROGRESS flag and update the write|verify|expire|repack functions in midx.h to accept a flags parameter. The MIDX_PROGRESS flag indicates whether the caller of the function would like progress information to be displayed. This patch only changes the method prototypes and does not change the functionality. The functionality change will be handled by a later patch William Baker via GitGitGadget
2019-09-20 20:01 ` Junio C Hamano
2019-09-20 20:16 ` Junio C Hamano
2019-09-21 12:11 ` [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip> SZEDER Gábor
2019-09-23 21:55 ` William Baker
2019-09-28 3:40 ` Junio C Hamano
2019-09-30 17:01 ` William Baker
2019-10-02 5:38 ` Junio C Hamano
2019-10-02 5:43 ` Junio C Hamano
2019-10-02 7:04 ` Junio C Hamano
2019-10-02 15:56 ` William Baker
2019-10-07 17:12 ` SZEDER Gábor
2019-10-07 17:29 ` SZEDER Gábor
2019-10-08 4:30 ` Junio C Hamano
2019-10-08 16:24 ` William Baker
2019-10-09 0:16 ` SZEDER Gábor [this message]
2019-10-09 1:32 ` SZEDER Gábor
2019-10-15 20:00 ` William Baker
2019-10-16 2:09 ` Junio C Hamano
2019-10-16 19:48 ` William Baker
2019-10-18 21:35 ` William Baker
2019-09-20 16:53 ` [PATCH v2 2/6] midx: add progress to write_midx_file Add progress to write_midx_file. Progress is displayed when the MIDX_PROGRESS flag is set William Baker via GitGitGadget
2019-09-20 20:10 ` Junio C Hamano
2019-09-23 21:12 ` William Baker
2019-09-28 3:49 ` Junio C Hamano
2019-09-30 16:36 ` William Baker
2019-09-20 16:53 ` [PATCH v2 3/6] midx: add progress to expire_midx_packs Add progress to expire_midx_packs. " William Baker via GitGitGadget
2019-09-20 16:53 ` [PATCH v2 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file Update verify_midx_file to only display progress " William Baker via GitGitGadget
2019-09-20 16:53 ` [PATCH v2 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack Update midx_repack " William Baker via GitGitGadget
2019-09-20 20:12 ` Junio C Hamano
2019-09-20 16:53 ` [PATCH v2 6/6] multi-pack-index: add [--[no-]progress] option. Add the --[no-]progress option to git multi-pack-index. Pass the MIDX_PROGRESS flag to the subcommand functions when progress should be displayed by multi-pack-index. The progress feature was added to 'verify' in 144d703 ("multi-pack-index: report progress during 'verify'", 2018-09-13) but some subcommands were not updated to display progress, and the ability to opt-out was overlooked William Baker via GitGitGadget
2019-09-20 19:54 ` [PATCH v2 0/6] multi-pack-index: add --no-progress Junio C Hamano
2019-09-20 20:33 ` William Baker
2019-09-20 20:23 ` Philip Oakley
2019-09-20 20:39 ` William Baker
2019-10-03 17:53 ` [PATCH v3 " William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 1/6] midx: add MIDX_PROGRESS flag William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 2/6] midx: add progress to write_midx_file William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 3/6] midx: add progress to expire_midx_packs William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack William Baker via GitGitGadget
2019-10-03 17:53 ` [PATCH v3 6/6] multi-pack-index: add [--[no-]progress] option William Baker via GitGitGadget
2019-10-03 22:46 ` [PATCH v3 0/6] multi-pack-index: add --no-progress Junio C Hamano
2019-10-21 18:39 ` [PATCH v4 " William Baker via GitGitGadget
2019-10-21 18:39 ` [PATCH v4 1/6] midx: add MIDX_PROGRESS flag William Baker via GitGitGadget
2019-10-21 18:39 ` [PATCH v4 2/6] midx: add progress to write_midx_file William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 3/6] midx: add progress to expire_midx_packs William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack William Baker via GitGitGadget
2019-10-21 18:40 ` [PATCH v4 6/6] multi-pack-index: add [--[no-]progress] option William Baker via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008232439.GA7212@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=William.Baker@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=stolee@gmail.com \
--cc=williamtbakeremail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).