git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Tan <jonathantanmy@google.com>
To: me@yadavpratyush.com
Cc: gitgitgadget@gmail.com, git@vger.kernel.org,
	hariom18599@gmail.com, gitster@pobox.com,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH 1/1] builtin/blame.c: constants into bit shift format
Date: Wed, 16 Oct 2019 12:37:50 -0700	[thread overview]
Message-ID: <20191016193750.258148-1-jonathantanmy@google.com> (raw)
In-Reply-To: <20191016191012.ij3zbexu7pxupdho@yadavpratyush.com>

> There was some discussion recently about converting these related 
> #defines to enums [0]. We might consider doing that here.
> 
> If you read through that entire thread, you'd see that there were some 
> disagreements about whether using enums for sets of bits is a good idea 
> ([1] and [2]), but it is at least something worth considering while we 
> are on this topic.
> 
> FWIW, I think it is a good idea to use an enum here.

[snip]

> [0] https://public-inbox.org/git/20191010115230.10623-1-wambui.karugax@gmail.com/
> [1] https://public-inbox.org/git/20191014182754.82302-1-jonathantanmy@google.com/
> [2] https://public-inbox.org/git/xmqqk19ag60g.fsf@gitster-ct.c.googlers.com/

Thanks for the handy references. You know my opinion on bitflags as
enums from reading them, but I think that we have already had that
discussion and came to a conclusion. So don't use an enum here.

The patch itself looks good, and I also prefer the bit shift format over
octal.

  reply	other threads:[~2019-10-16 19:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 18:30 [PATCH 0/1] builtin/blame.c: bit field constants into bit shift format Hariom Verma via GitGitGadget
2019-10-16 18:30 ` [PATCH 1/1] builtin/blame.c: " Hariom Verma via GitGitGadget
2019-10-16 19:10   ` Pratyush Yadav
2019-10-16 19:37     ` Jonathan Tan [this message]
2019-10-16 19:44       ` Pratyush Yadav
2019-10-17  7:38   ` Junio C Hamano
2019-10-17  7:33 ` [PATCH 0/1] builtin/blame.c: bit field " Junio C Hamano
2019-10-17 17:46 ` [PATCH v2 " Hariom Verma via GitGitGadget
2019-10-17 17:46   ` [PATCH v2 1/1] builtin/blame.c: " Hariom Verma via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016193750.258148-1-jonathantanmy@google.com \
    --to=jonathantanmy@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=hariom18599@gmail.com \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).