From: Peter Jones <pjones@redhat.com>
To: git@vger.kernel.org
Cc: Peter Jones <pjones@redhat.com>
Subject: [PATCH 2/2] Make "git branch -d" prune missing worktrees automatically.
Date: Thu, 17 Oct 2019 12:28:26 -0400 [thread overview]
Message-ID: <20191017162826.1064257-2-pjones@redhat.com> (raw)
In-Reply-To: <20191017162826.1064257-1-pjones@redhat.com>
Currently, if you do:
$ git branch zonk origin/master
$ git worktree add zonk zonk
$ rm -rf zonk
$ git branch -d zonk
You get the following error:
$ git branch -d zonk
error: Cannot delete branch 'zonk' checked out at '/home/pjones/devel/kernel.org/git/zonk'
It isn't meaningfully checked out, the repo's data is just stale and no
longer reflects reality.
This makes it so that if nothing is present where a worktree is
supposedly checked out, deleting the branch will automatically prune it.
Signed-off-by: Peter Jones <pjones@redhat.com>
---
builtin/branch.c | 2 +-
builtin/worktree.c | 14 ++++++++++++++
worktree.h | 6 ++++++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/builtin/branch.c b/builtin/branch.c
index 2ef214632f0..d611f8183b4 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -236,7 +236,7 @@ static int delete_branches(int argc, const char **argv, int force, int kinds,
if (kinds == FILTER_REFS_BRANCHES) {
const struct worktree *wt =
find_shared_symref("HEAD", name);
- if (wt) {
+ if (wt && prune_worktree_if_missing(wt) < 0) {
error(_("Cannot delete branch '%s' "
"checked out at '%s'"),
bname.buf, wt->path);
diff --git a/builtin/worktree.c b/builtin/worktree.c
index 4de44f579af..b3ad915c3c3 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -133,6 +133,20 @@ static int prune_worktree(const char *id, struct strbuf *reason)
return 0;
}
+int prune_worktree_if_missing(const struct worktree *wt)
+{
+ struct strbuf reason = STRBUF_INIT;
+
+ if (access(wt->path, F_OK) >= 0 ||
+ (errno != ENOENT && errno == ENOTDIR)) {
+ errno = EEXIST;
+ return -1;
+ }
+
+ strbuf_addf(&reason, _("Removing worktrees/%s: worktree directory is not present"), wt->id);
+ return prune_worktree(wt->id, &reason);
+}
+
static void prune_worktrees(void)
{
struct strbuf reason = STRBUF_INIT;
diff --git a/worktree.h b/worktree.h
index caecc7a281c..75762c25752 100644
--- a/worktree.h
+++ b/worktree.h
@@ -132,4 +132,10 @@ void strbuf_worktree_ref(const struct worktree *wt,
const char *worktree_ref(const struct worktree *wt,
const char *refname);
+/*
+ * Prune a worktree if it is no longer present at the checked out location.
+ * Returns < 0 if the checkout is there or if pruning fails.
+ */
+int prune_worktree_if_missing(const struct worktree *wt);
+
#endif
--
2.23.0
next prev parent reply other threads:[~2019-10-17 16:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 16:28 [PATCH 1/2] Make die_if_checked_out() ignore missing worktree checkouts Peter Jones
2019-10-17 16:28 ` Peter Jones [this message]
2019-10-17 17:28 ` [PATCH 2/2] Make "git branch -d" prune missing worktrees automatically Eric Sunshine
2019-10-18 19:43 ` Peter Jones
2019-10-18 19:45 ` [PATCH v2 1/4] libgit: Add a read-only helper to test the worktree lock Peter Jones
2019-10-18 19:45 ` [PATCH v2 2/4] libgit: Expose more worktree functionality Peter Jones
2019-10-21 1:59 ` Junio C Hamano
2019-10-18 19:45 ` [PATCH v2 3/4] Make die_if_checked_out() prune missing checkouts of unlocked worktrees Peter Jones
2019-10-21 2:09 ` Junio C Hamano
2019-10-18 19:45 ` [PATCH v2 4/4] Make "git branch -d" prune missing worktrees automatically Peter Jones
2019-10-21 1:36 ` [PATCH v2 1/4] libgit: Add a read-only helper to test the worktree lock Junio C Hamano
2019-11-08 10:14 ` [PATCH 2/2] Make "git branch -d" prune missing worktrees automatically Eric Sunshine
2019-11-08 14:56 ` Phillip Wood
2019-11-09 11:34 ` Eric Sunshine
2019-10-17 16:44 ` [PATCH 1/2] Make die_if_checked_out() ignore missing worktree checkouts SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017162826.1064257-2-pjones@redhat.com \
--to=pjones@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).