From: Pratyush Yadav <me@yadavpratyush.com>
To: Birger Skogeng Pedersen <birger.sp@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] git-gui: implement proc select_path_in_widget
Date: Thu, 17 Oct 2019 23:58:34 +0530 [thread overview]
Message-ID: <20191017182833.rzk6r6egmvpmjtns@yadavpratyush.com> (raw)
In-Reply-To: <CAGr--=Ltx2JPexfVSWRrAdT0zHs0RWaZdS7OZD-TWJv2y7K-PA@mail.gmail.com>
On 17/10/19 07:08AM, Birger Skogeng Pedersen wrote:
> Hi Pratyush,
>
> On Wed, Oct 16, 2019 at 9:28 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> > I mentioned this earlier, and I'll mention this again: I'm not sure
> > whether this feature would be a good thing for the larger population. So
> > this _might_ not end up being accepted depending on how people react to
> > the proposal. I thought I'd let you know to avoid any nasty surprises
> > later.
>
> Could you please elaborate on why you think the feature might be
> undesired? Why would users not want a staged file to be selected
> automatically?
I have similar arguments to what Philip said in the GitHub link you
sent. I think software should do what the user tells it to do, and
should not try to "second guess" them. This second guessing can get
annoying.
So if I select the commit message buffer, I told the software to select
it by clicking it. I did not tell it to switch my diff view. This switch
of view can prove to be disorienting/confusing to a user because they
did not select any diff. They selected a text box.
At the very least, I think we should have a config option, and it should
be turned off by default. That said, I'd certainly like to hear what
other people think on this topic.
> FWIW I've also got 2 comments on this in GH[1].
>
> [1] https://github.com/git-for-windows/git/issues/2341
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-10-17 18:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 12:24 git-gui: automatically move focus to staged file before typing commit message? Birger Skogeng Pedersen
2019-09-14 21:15 ` Pratyush Yadav
2019-09-14 21:26 ` Johannes Sixt
2019-09-14 21:27 ` Pratyush Yadav
2019-09-15 7:55 ` Birger Skogeng Pedersen
2019-09-16 18:01 ` Pratyush Yadav
2019-09-26 18:33 ` Birger Skogeng Pedersen
2019-09-26 19:30 ` Pratyush Yadav
2019-09-26 21:17 ` Birger Skogeng Pedersen
2019-10-07 16:52 ` Birger Skogeng Pedersen
2019-10-07 17:11 ` [PATCH 1/2] git-gui: implement proc select_path_in_widget Birger Skogeng Pedersen
2019-10-07 17:11 ` [PATCH 2/2] git-gui: select staged on ui_comm focus Birger Skogeng Pedersen
2019-10-16 19:25 ` Pratyush Yadav
2019-10-13 20:21 ` [PATCH 1/2] git-gui: implement proc select_path_in_widget Pratyush Yadav
2019-10-15 10:51 ` Birger Skogeng Pedersen
2019-10-16 19:28 ` Pratyush Yadav
2019-10-17 5:08 ` Birger Skogeng Pedersen
2019-10-17 5:33 ` Johannes Sixt
2019-10-17 6:54 ` Birger Skogeng Pedersen
2019-10-17 18:28 ` Pratyush Yadav [this message]
2019-10-08 17:59 ` git-gui: automatically move focus to staged file before typing commit message? Pratyush Yadav
2019-10-08 19:46 ` Birger Skogeng Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017182833.rzk6r6egmvpmjtns@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).