git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: Git Test Coverage Report (October 11)
Date: Wed, 23 Oct 2019 19:00:49 +0200	[thread overview]
Message-ID: <20191023170049.hnzb22iiflrigyfs@tb-raspi4> (raw)
In-Reply-To: <c863c09b-f0ed-19c6-356e-12a3ecbc08b9@gmail.com>

On Fri, Oct 11, 2019 at 09:33:11AM -0400, Derrick Stolee wrote:
> Here is today's test coverage report. The usual report format is
> available online [1], [2]. The report listed below is a new format
> that groups lines by the commit that introduced them [3]. Thanks
> Peff for the feedback on that idea.
>

[]
>
> Torsten Bögershausen	ebb8d2c9 mingw: support UNC in git clone file://server/share/repo
> connect.c
> ebb8d2c9 921) path = host - 2; /* include the leading "//" */
>

I actually looked into this one, and my understanding is that the code path
makes only sense for windows and is only tested on Windows in t5500.
(Linux/Unix/POSIX don't use UNC path names starting with "//" )

How can we avoid those "not covered by test" warnings?

One solution could be to use

#ifndef has_dos_drive_prefix
#define has_dos_drive_prefix(a) 0
#endif

in git-compat-util.h and hope that the compiler is smart enough
to optimize away that line of code.

Another way could be to have #ifdefs in connect.c, so that it
is clear "this is Windows only".

Or make a comment for the "cover report" saying "not covered".

Are there any good or better thoughts on this ?





  parent reply	other threads:[~2019-10-23 17:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 13:33 Git Test Coverage Report (October 11) Derrick Stolee
2019-10-17  6:46 ` Jeff King
2019-10-23 17:00 ` Torsten Bögershausen [this message]
2019-10-23 18:07   ` Derrick Stolee
2019-10-24 15:25     ` Torsten Bögershausen
2019-10-24 17:04       ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023170049.hnzb22iiflrigyfs@tb-raspi4 \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).