git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emily Shaffer <emilyshaffer@google.com>
To: Heba Waly via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Heba Waly <heba.waly@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/1] documentation: remove empty doc files
Date: Wed, 23 Oct 2019 14:44:04 -0700	[thread overview]
Message-ID: <20191023214404.GB124161@google.com> (raw)
In-Reply-To: <5cd79e24fe6bde7c5d10e1c2cae660858e3c4051.1571815556.git.gitgitgadget@gmail.com>

On Wed, Oct 23, 2019 at 07:25:56AM +0000, Heba Waly via GitGitGadget wrote:
> From: Heba Waly <heba.waly@gmail.com>
> 
> Remove empty and redundant documentation files from the
> Documentation/technical/ directory.
> 
> The empty doc files included only TODO messages with no documentation for
> years. Instead an approach is being taken to keep all doc beside the code
> in the relevant header files.
> Having empty doc files is confusing and disappointing to anybody looking
> for information, besides having the documentation in header files makes it
> easier for developers to find the information they are looking for.
> 
> here's a list of the files removed and if the info can be found in the
> corresponding header file:
I think you can remove the above; in lots of composition contexts it
tends to be bad form to say "Here is <something>: <something>" - don't
warn us that you're going to present it, just present it. :) (Or, at
least, this has been drilled into my head by many high school English
teachers...)

Maybe you could say something like, "Some of the content which could
have gone here already exists elsewhere:"  If you take that suggestion,
you can probably move grep.h to the bottom, as it's the exception which
doesn't have content that exists elsewhere.

> 1- Documentation/technical/api-grep.txt -> grep.h does not have enough
> documentation at the moment.
> 2- Documentation/technical/api-object-access.txt -> sha1-file.c and
> object.h have some details
> 3- Documentation/technical/api-quote.txt -> quote.h has some details.
> 4- Documentation/technical/api-xdiff-interface.txt -> xdiff-interface.h has
> some details.

For this list, I think you can remove the numbered bullet, and the
leading "Documentation/technical/" - we can see the files deleted from
the diff.

 - Emily

  reply	other threads:[~2019-10-23 21:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22 18:19 [PATCH 0/1] [Outreachy] documentation: remove empty doc files Heba Waly via GitGitGadget
2019-10-22 18:19 ` [PATCH 1/1] " Heba Waly via GitGitGadget
2019-10-22 21:04   ` Emily Shaffer
2019-10-22 23:51     ` Junio C Hamano
2019-10-23  7:23       ` Heba Waly
2019-10-23  7:22     ` Heba Waly
2019-10-23  7:25 ` [PATCH v2 0/1] [Outreachy] " Heba Waly via GitGitGadget
2019-10-23  7:25   ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2019-10-23 21:44     ` Emily Shaffer [this message]
2019-10-24 10:43       ` Heba Waly
2019-10-24 11:29   ` [PATCH v3 0/1] [Outreachy] " Heba Waly via GitGitGadget
2019-10-24 11:29     ` [PATCH v3 1/1] " Heba Waly via GitGitGadget
2019-10-24 20:48       ` Emily Shaffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023214404.GB124161@google.com \
    --to=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=heba.waly@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).