git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Hesse <mail@eworm.de>
To: Jeff King <peff@peff.net>
Cc: Jeff Hostetler <git@jeffhostetler.com>,
	Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>,
	Jeff Hostetler <jeffhost@microsoft.com>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: Re: cgit and global configuration
Date: Fri, 25 Oct 2019 18:10:15 +0200	[thread overview]
Message-ID: <20191025181015.50bf2b92@leda> (raw)
In-Reply-To: <20190612190845.GA14949@sigill.intra.peff.net>

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

Jeff King <peff@peff.net> on Wed, 2019/06/12 15:08:
> On Tue, Jun 11, 2019 at 04:22:32PM -0400, Jeff Hostetler wrote:
> 
> > As for going forward, I see 3 options:
> > 
> > [1] update your tests to allow this.  (I didn't dig thru your
> >     tests to see how extensive this might be.)
> > 
> > [2] define your own version of common-main.c and link with it
> >     instead of git/common-main.c and delete the calls to trace2_*()
> >     in it.
> > 
> > [3] define your own version of common-main.c and then call your
> >     prepare_repo_env() prior to trace2_initialize().
> > 
> > Granted, I've only spent 15 minutes looking at your code, so
> > I may be mistaken about several things, but I think those are
> > your options.  
> 
> After reading the original report, my instinct was that (2) or (3) is
> probably the right way forward. We could make it a little easier for
> them by splitting up common-main a bit into two parts:
> [...]

We decided to go another way and introduced a constructor function which does
initial environment setup:

https://git.zx2c4.com/cgit/commit/?id=034e3c7d56ba71ce281886fe8525b16d4559fac1

Everything (including tests) is happy with that.
-- 
Best regards,
Chris

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-10-25 16:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 15:04 cgit and global configuration Christian Hesse
2019-06-11 19:55 ` Junio C Hamano
2019-06-11 20:22 ` Jeff Hostetler
2019-06-12 19:08   ` Jeff King
2019-10-25 16:10     ` Christian Hesse [this message]
2019-10-25 21:24       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025181015.50bf2b92@leda \
    --to=mail@eworm.de \
    --cc=Jason@zx2c4.com \
    --cc=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).