git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kipras Melnikovas <kipras@kipras.org>
To: gitster@pobox.com
Cc: dev@kipras.org, git@vger.kernel.org, ungureanupaulsebastian@gmail.com
Subject: Re: Re: [FR] Allow `git stash create` to include untracked changes
Date: Mon, 28 Oct 2019 18:03:05 +0200	[thread overview]
Message-ID: <20191028160305.169851-1-kipras@kipras.org> (raw)
In-Reply-To: <xmqqa79lbpte.fsf@gitster-ct.c.googlers.com>

Hello,
thank you for the info.

It seems like neither worked:

export GIT_TEST_STASH_USE_BUILTIN=no
git config --global stash.usebuiltin no

The untracked files are still not stashed with `git stash create -u [some-argument]`, but are stashed successfully with `git stash push -u`,
so unless I'm doing something wrong, this also doesn't help, sadly.

Also, if there are no modified changes (only untracked ones), then `git stash create [-u [some-arg]]` (the non-builtin stash) will not even give you a commit object's name, thus it probably does not create the commit object at all.

Also, the manual page of git-stash(1) not mention the `--include-untracked` option - this is why I posted in the first place.

$ man git-stash
...
git stash create [<message>]
git stash store [-m|--message <message>] [-q|--quiet] <commit>
...

---

Is there any chance to

* get the builtin stash to support `--include-untracked` option?

* figure out if the legacy stash also works as intended with the `-u [some-arg]` option
	* when there aren't any changes, except untracked/ignored ones, the commit object doesn't seem to be created (printed) at all
	* why does it even require an argument?

* update the manual page for git-stash(1)

* check if everything's fine with `git stash store` too, just in case:D

Is there anything else I need to do to get this issue reported or are you guys taking care of it?

---

My stuff:

$ git --version
git version 2.23.0

$ uname -a
Linux arch-usb 5.3.7-arch1-1-ARCH #1 SMP PREEMPT Fri Oct 18 00:17:03 UTC 2019 x86_64 GNU/Linux

Thank you for your time and support:)
Kipras


  reply	other threads:[~2019-10-28 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26 14:38 [FR] Allow `git stash create` to include untracked changes dev
2019-10-28  1:51 ` Junio C Hamano
2019-10-28 16:03   ` Kipras Melnikovas [this message]
2019-10-29  7:29   ` Johannes Schindelin
2019-10-31 13:40     ` Thomas Gummerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028160305.169851-1-kipras@kipras.org \
    --to=kipras@kipras.org \
    --cc=dev@kipras.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ungureanupaulsebastian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).