From: Jonathan Nieder <jrnieder@gmail.com>
To: Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH 1/1] help: add gitsubmodules to the list of guides
Date: Mon, 28 Oct 2019 14:51:04 -0700 [thread overview]
Message-ID: <20191028215104.GC12487@google.com> (raw)
In-Reply-To: <8026c7e9ab2f60af770fa66097d3220259201d8f.1572267946.git.gitgitgadget@gmail.com>
Philippe Blain wrote:
> The guide "gitsubmodules" was added in d480345 (submodules: overhaul
> documentation, 2017-06-22), but it was not added to
> command-list.txt when commit 1b81d8c (help: use command-list.txt
> for the source of guides, 2018-05-20) taught "git help" to obtain the
> guide list from this file.
>
> Add it now, and capitalize the first word of the description of
> gitsubmodules, as was done in 1b81d8c (help: use command-list.txt
> for the source of guides, 2018-05-20) for the other guides.
>
> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
> ---
> Documentation/gitsubmodules.txt | 2 +-
> command-list.txt | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Good catch. Thanks for taking care of it.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2019-10-28 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 13:05 [PATCH 0/1] help: add gitsubmodules to the list of guides Philippe Blain via GitGitGadget
2019-10-28 13:05 ` [PATCH 1/1] " Philippe Blain via GitGitGadget
2019-10-28 21:51 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028215104.GC12487@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=levraiphilippeblain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).