From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Luke Dashjr <luke@dashjr.org>,
git@vger.kernel.org
Subject: Re: GIT_COMMITTER_* and reflog
Date: Tue, 29 Oct 2019 10:34:20 -0400 [thread overview]
Message-ID: <20191029143420.GB3683@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqr22ybcs7.fsf@gitster-ct.c.googlers.com>
On Sun, Oct 27, 2019 at 09:20:24PM +0900, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > If somebody wants to pursue a patch, I suspect the solution is probably
> > something like this (totally untested):
>
> Looks sensible. It is very much unsatisfying that datestamp(),
> which is used by fmt_ident() when no date string is given, seems to
> totally bypass date.c::get_time(), which means the framework to give
> fake timestamp via GIT_TEST_DATE_NOW cannot be used to write
> reproducible tests.
>
> Given that datestamp() is only used by the push certificate and
> fast-import codepaths and nowhere else, I suspect that "fixing" it
> retroactively to honor GIT_TEST_DATE_NOW would not have any negative
> fallout, but that's not something I should be contemplating on
> during the -rc period ;-)
Yeah, I agree datestamp() should respect $GIT_TEST_DATE_NOW. This whole
topic is not something for the -rc period, I would think.
-Peff
prev parent reply other threads:[~2019-10-29 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 21:49 GIT_COMMITTER_* and reflog Luke Dashjr
2019-10-26 2:20 ` Jonathan Nieder
2019-10-26 2:43 ` Luke Dashjr
2019-11-07 13:57 ` Philip Oakley
2019-10-26 7:34 ` Junio C Hamano
2019-10-26 17:37 ` Jeff King
2019-10-27 12:20 ` Junio C Hamano
2019-10-29 14:05 ` Phillip Wood
2019-10-29 14:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029143420.GB3683@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=luke@dashjr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).