Re: [PATCH 0/1] Allow the 'revert' option in Git Gui to operate on untracked files, deleting them

From: Pratyush Yadav <me@yadavpratyush.com>
To: Jonathan Gilbert <logic@deltaq.org>
Cc: "Bert Wesarg bert.wesarg-at-googlemail.com |GitHub
	Public/Example Allow|"  <xlwsizdz58ciy7t@sneakemail.com>,
	Jonathan Gilbert via GitGitGadget <gitgitgadget@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Jonathan Gilbert <rcq8n2xf3v@liamekaens.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/1] Allow the 'revert' option in Git Gui to operate on untracked files, deleting them
Date: Wed, 30 Oct 2019 03:13:49 +0530	[thread overview]
Message-ID: <20191029214349.iffk37psv3n4v47y@yadavpratyush.com> (raw)
In-Reply-To: <CAPSOpYsA9n6Y1vH1_+vRTCV7Mrvox4L2LpQmpXBnpH8ke0yDhQ@mail.gmail.com>

On 29/10/19 03:25PM, Jonathan Gilbert wrote:
> That's kind of neat, I wasn't aware of that facet of Git Gui :-) But,
> it isn't quite the same feature:
> 
> * It has to be manually set up on each installation.
> * It invokes an external process, I don't know if it's safe to assume
> that "rm" will work on all platforms (though I just tested it on my
> Windows installation and it worked).
> * It doesn't remove directories that it makes empty.
> * I don't see a way to bind it to a keyboard shortcut. That could just
> be me not knowing enough about custom tools, though. :-)

You can't as of now. Harish was in the process of implementing this [0], 
but I left some comments and he hasn't re-rolled the patch since. So 
unless I find some time to tie it up, this will remain un-implemented. 

Of course, if you'd like to see that feature in git-gui, feel free to 
pick it up and brush up the changes :). The latest version can be found 
at [1]. But it does not have a proper commit message (apart from the 
other changes I suggested) since Harish did not format the patch 
correctly when sending.

> * It only processes the first file selected.
> * If I select a tracked file, it will still delete it, and the feature
> I'm looking for is more of a "return repository to clean state" type
> function, like "revert" already is but extended to handle files that
> you can't actually "git revert".

[0] https://public-inbox.org/git/CACV9s2MQCP04QASgt0xhi3cSNPSKjwXTufxmZQXAUNvnWD9DSw@mail.gmail.com/ 
[1] https://github.com/prati0100/git-gui/tree/hk/custom-keyboard-shortcuts

-- 
Regards,
Pratyush Yadav